Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InsertAndReplaceContentControls is broken for files being edited by multiple users #74

Open
Neverbolt opened this issue Jul 25, 2019 · 3 comments
Assignees
Labels
confirmed-bug Issues with confirmed bugs

Comments

@Neverbolt
Copy link

Do you want to request a feature or report a bug?
This is a bug with the "InsertAndReplaceContentControls" feature.

What is the current behavior?
Step 1:
Put the sdkjs-plugins/examples/example_insert_content_and_document folder into sdkjs-plugins/ to install the provided example plugin. (This issue exists with other uses of the "InsertAndReplaceContentControls" command as well, however, this is a good common ground)

Step 2:
Create a shared document and open it. Run the "Example insert content & document" plugin. It works as expected and inserts the 7 content controls.

Step 3:
Now open the document with two users simultaneously. Place the cursor at the end of the document and run the plugin again. It works as expected and inserts the 7 content controls again.

Step 4:
Make a page break (not needed, but makes it easier to visualize) and then type some arbitrary text with one user.
Place the cursor of the other user somewhere INSIDE of that text and run the plugin again.

The window freezes and nothing works anymore, no content control is inserted and the page needs to be reloaded.

What is the expected behavior?
It should be possible to insert content controls inside of existing text.

Which versions of sdkjs-plugins, and which browser / OS are affected by this issue? Did this work in previous versions of sdkjs-plugins?
I have the version 5.2.8.24 and am using the provided docker installation from the "Linux Docker Image" over at https://www.onlyoffice.com/download.aspx

@Neverbolt
Copy link
Author

Any updates on this / ways I can help?

@flaminestone
Copy link

Hello @Neverbolt, Yes, it is bug, thank you. It should be fixed in future versions

@ShockwaveNN ShockwaveNN added the confirmed-bug Issues with confirmed bugs label Aug 12, 2019
@Neverbolt
Copy link
Author

Hello @flaminestone , is there any update yet? or any kind of eta no matter how vague?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed-bug Issues with confirmed bugs
Projects
None yet
Development

No branches or pull requests

4 participants