Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add drafts to howtos and questions #3547

Merged
merged 7 commits into from
May 21, 2024

Conversation

mariojsnunes
Copy link
Collaborator

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Ensures only accepted items appear on the howtos and questions list.
Adds a new section to display the user's non-accepted howto and question items.

Git Issues

Closes #3540

@mariojsnunes mariojsnunes requested a review from a team as a code owner May 15, 2024 05:53
Copy link

cypress bot commented May 15, 2024

Passing run #5633 ↗︎

0 81 1 0 Flakiness 0

Details:

Merge branch 'master' into feat/howto-question-drafts
Project: onearmy-community-platform Commit: 3c0d22a999
Status: Passed Duration: 04:35 💡
Started: May 21, 2024 9:36 AM Ended: May 21, 2024 9:41 AM

Review all test suite changes for PR #3547 ↗︎

Copy link
Member

@benfurber benfurber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. A few minor thoughts, but feel free to ignore them. And like I said on discord, I think that failing question read test can be commented out until we sort the db mocking stuff.

src/pages/Howto/Content/HowtoList/HowtoList.tsx Outdated Show resolved Hide resolved
src/pages/Question/QuestionListing.tsx Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 68.09%. Comparing base (0583526) to head (3c0d22a).

Files Patch % Lines
src/pages/Howto/Content/HowtoList/HowtoList.tsx 0.00% 19 Missing ⚠️
src/pages/Howto/howto.service.ts 37.50% 10 Missing ⚠️
src/pages/Question/question.service.ts 28.57% 10 Missing ⚠️
src/pages/Question/QuestionListing.tsx 73.68% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3547      +/-   ##
==========================================
- Coverage   68.25%   68.09%   -0.16%     
==========================================
  Files         441      441              
  Lines       13925    13972      +47     
  Branches     2489     2507      +18     
==========================================
+ Hits         9504     9514      +10     
- Misses       4373     4409      +36     
- Partials       48       49       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mariojsnunes mariojsnunes merged commit 2a3d42e into ONEARMY:master May 21, 2024
20 checks passed
@mariojsnunes mariojsnunes deleted the feat/howto-question-drafts branch May 21, 2024 09:41
@cypress cypress bot mentioned this pull request May 21, 2024
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.184.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.182.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add draft filtering/display to how-tos
3 participants