-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] No warning when editing a comment to an empty comment #3411
Comments
Thanks @sorikang0806, a really good spot! Looks like the EditComment component and the CreateComment component should share more code so that the behaviour is consistent. |
Hi, I would like to work on this. After looking through the code I have made some obs
|
🎉 This issue has been resolved in version 1.183.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This issue has been resolved in version 1.185.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Describe the bug
There is no warning or error message that notifies the user that an edited comment cannot be empty.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
When the save button is clicked, display a warning message that a comment cannot be empty
Screenshots
Additional context
I am a newbie here and want to try fixing this bug myself first if that is okay!
The text was updated successfully, but these errors were encountered: