Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should provide time-out functionality #107

Open
msuchard opened this issue Jun 20, 2023 · 2 comments
Open

We should provide time-out functionality #107

msuchard opened this issue Jun 20, 2023 · 2 comments

Comments

@msuchard
Copy link
Member

Really helpful in some data sources would be a time-out feature in which the package kills a query (and then importantly continues onto the next task) that executes for longer than a specified time.

Might this be easily feasible @azimov @anthonysena ?

@azimov
Copy link
Collaborator

azimov commented Jun 20, 2023

I think this should be possible to implement with something like R.utils::withTimeout though we would need to test how well this plays with DatabaseConnector and its calls to java.

I think there are some other questions about the default behaviour - I assume this is to have no timeout rather than assert that no cohort should take more than 10 hours to execute?

@anthonysena
Copy link
Collaborator

Think we'll need to think about the behavior but seems possible and reasonable. I suppose we'd want to apply a uniform timeout to call cohort generations in this case. I agree with @azimov that we'd want to test this out to make sure that the timeout plays nicely with database connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

3 participants