Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.15.92-dfl (struct device *)’ from incompatible pointer type ‘int (*)(struct device *)’ [-Werror=incompatible-pointer-types] .remove = dfl_bus_remove, #18

Open
208yunyao opened this issue May 16, 2023 · 3 comments
Open

5.15.92-dfl (struct device *)’ from incompatible pointer type ‘int (*)(struct device *)’ [-Werror=incompatible-pointer-types] .remove = dfl_bus_remove, #18

208yunyao opened this issue May 16, 2023 · 3 comments
Assignees
@rweight @fpgamatt

Comments

@208yunyao
Copy link

[root@localhost linux-dfl]# sudo make install
sh ./arch/x86/boot/install.sh 5.15.92-dfl
arch/x86/boot/bzImage System.map "/boot"
dkms: running auto installation service for kernel 5.15.92-dfl
Deprecated feature: REMAKE_INITRD (/var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/sourc e/dkms.conf)
Deprecated feature: REMAKE_INITRD (/etc/dkms/framework.conf)
Sign command: /lib/modules/5.15.92-dfl/build/scripts/sign-file
Signing key: /var/lib/dkms/mok.key
Public certificate (MOK): /var/lib/dkms/mok.pub
Deprecated feature: REMAKE_INITRD (/var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/sourc e/dkms.conf)

Building module:
Cleaning build area...
make -j112 KERNELRELEASE=5.15.92-dfl KERNELDIR=/lib/modules/5.15.92-dfl/build...(bad exit status: 2)
Error! Bad return status for module build on kernel: 5.15.92-dfl (x86_64)
Consult /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/make.log for more informat ion.
Error! One or more modules failed to install during autoinstall.
Refer to previous errors for more information.
Failed.
/usr/lib/dracut/dracut.conf.d/90-linux-dfl-backport.conf:omit_drivers+="dfl_pci n5010_hssi n5010_phy s10hss i ptp_dfl_tod intel_m10_bmc_sec_update intel_m10_bmc_hwmon intel_m10_bmc_log intel_m10_bmc_pmci intel_m10_b mc_spi intel_m10_bmc intel_s10_phy qsfp_mem regmap_indirect_register spi_altera_dfl spi_altera_core uio_dfl dfl_emif dfl_n3000_nios dfl_hssi dfl_fme_br dfl_fme_region dfl_fme_mgr dfl_intel_s10_iopll dfl_afu dfl_fme dfl fpga_image_load fpga_region fpga_bridge fpga_mgr regmap_spi_avmm regmap_mmio"

dracut: WARNING: +=" ": should have surrounding white spaces!
dracut: WARNING: This will lead to unwanted side effects! Please fix the configuration file.

[root@localhost linux-dfl]# uname -a
Linux localhost.localdomain 4.18.0-483.el8.x86_64 #1 SMP Fri Mar 31 13:24:48 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
[root@localhost linux-dfl]# vim /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/make.log
CC [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/net/ethernet/silicom/n5010-phy.o
CC [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/net/ethernet/silicom/n5010-hssi.o
CC [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/fpga/dfl-pci.o
/var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/fpga/dfl.c:277:54: warning: "RHEL_RELEASE_CODE" is not defined, evaluates to 0 [-Wundef]
#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 16, 0) && RHEL_RELEASE_CODE < 0x901
^~~~~~~~~~~~~~~~~
/var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/fpga/dfl.c: In function ‘dfl_bus_remove’:
/var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/fpga/dfl.c:289:54: warning: "RHEL_RELEASE_CODE" is not defined, evaluates to 0 [-Wundef]
#if LINUX_VERSION_CODE < KERNEL_VERSION(5, 16, 0) && RHEL_RELEASE_CODE < 0x901
^~~~~~~~~~~~~~~~~
/var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/fpga/dfl.c: At top level:
/var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/fpga/dfl.c:331:13: error: initialization of ‘void (*)(struct device )’ from incompatible pointer type ‘int ()(struct device *)’ [-Werror=incompatible-pointer-types]
.remove = dfl_bus_remove,
^~~~~~~~~~~~~~
/var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/drivers/fpga/dfl.c:331:13: note: (near initialization for ‘dfl_bus_type.remove’)
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-fme-region.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-fme-br.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-hssi.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-emif.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/uio-dfl.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-fme-mgr.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/fpga-region.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/intel-m10-bmc-log.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/intel-m10-bmc-spi.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/intel-m10-bmc-hwmon.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/intel-m10-bmc-pmci.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-intel-s10-iopll.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/spi-altera-dfl.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/fpga-bridge.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/intel-s10-phy.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/fpga-image-load.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/ptp_dfl_tod.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/fpga-mgr.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/regmap-indirect-register.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-fme.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-afu.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-pci.o
LD [M] /var/lib/dkms/linux-dfl-backport/0^20220501gsil1.8.r12.gac66976f-1/build/dfl-n3000-nios.o
cc1: some warnings being treated as errors
@chipb-intel
Copy link

@fpgamatt -- Is this something you can help with?

@rweight
Copy link
Contributor

rweight commented May 16, 2023 •
edited

The first concern I see is that both the linux-dfl kernel and the linux-dfl-backport driver are installed. The linux-dfl kernel has the DFL drivers included. Installing the linux-dfl-backport package (which delivers the DFL drivers separately) on top of that is likely to create confusion, and sometimes unexpected behavior.

If you are OK using the linux-dfl kernel, then my recommendation is to uninstall the linux-dfl-backport package. I think the compilation errors and warnings are all associated with building the linux-dfl-backport dkms driver. Removing the package should clear those errors.

Also note that the latest linux-dfl development is on the fpga-ofs-dev-6.1-lts branch with kernel version 6.1.27.

@rweight rweight self-assigned this May 16, 2023
@isaacncz
Copy link

isaacncz commented Jul 4, 2023 •
edited

@208yunyao i faced the same issue. Do you have the workaround?

rweight pushed a commit that referenced this issue Jul 25, 2023
@cdkey @gregkh
SUNRPC: Fix UAF in svc_tcp_listen_data_ready()
ef04741 
commit fc80fc2 upstream.

After the listener svc_sock is freed, and before invoking svc_tcp_accept()
for the established child sock, there is a window that the newsock
retaining a freed listener svc_sock in sk_user_data which cloning from
parent. In the race window, if data is received on the newsock, we will
observe use-after-free report in svc_tcp_listen_data_ready().

Reproduce by two tasks:

1. while :; do rpc.nfsd 0 ; rpc.nfsd; done
2. while :; do echo "" | ncat -4 127.0.0.1 2049 ; done

KASAN report:

  ==================================================================
  BUG: KASAN: slab-use-after-free in svc_tcp_listen_data_ready+0x1cf/0x1f0 [sunrpc]
  Read of size 8 at addr ffff888139d96228 by task nc/102553
  CPU: 7 PID: 102553 Comm: nc Not tainted 6.3.0+ #18
  Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 11/12/2020
  Call Trace:
   <IRQ>
   dump_stack_lvl+0x33/0x50
   print_address_description.constprop.0+0x27/0x310
   print_report+0x3e/0x70
   kasan_report+0xae/0xe0
   svc_tcp_listen_data_ready+0x1cf/0x1f0 [sunrpc]
   tcp_data_queue+0x9f4/0x20e0
   tcp_rcv_established+0x666/0x1f60
   tcp_v4_do_rcv+0x51c/0x850
   tcp_v4_rcv+0x23fc/0x2e80
   ip_protocol_deliver_rcu+0x62/0x300
   ip_local_deliver_finish+0x267/0x350
   ip_local_deliver+0x18b/0x2d0
   ip_rcv+0x2fb/0x370
   __netif_receive_skb_one_core+0x166/0x1b0
   process_backlog+0x24c/0x5e0
   __napi_poll+0xa2/0x500
   net_rx_action+0x854/0xc90
   __do_softirq+0x1bb/0x5de
   do_softirq+0xcb/0x100
   </IRQ>
   <TASK>
   ...
   </TASK>

  Allocated by task 102371:
   kasan_save_stack+0x1e/0x40
   kasan_set_track+0x21/0x30
   __kasan_kmalloc+0x7b/0x90
   svc_setup_socket+0x52/0x4f0 [sunrpc]
   svc_addsock+0x20d/0x400 [sunrpc]
   __write_ports_addfd+0x209/0x390 [nfsd]
   write_ports+0x239/0x2c0 [nfsd]
   nfsctl_transaction_write+0xac/0x110 [nfsd]
   vfs_write+0x1c3/0xae0
   ksys_write+0xed/0x1c0
   do_syscall_64+0x38/0x90
   entry_SYSCALL_64_after_hwframe+0x72/0xdc

  Freed by task 102551:
   kasan_save_stack+0x1e/0x40
   kasan_set_track+0x21/0x30
   kasan_save_free_info+0x2a/0x50
   __kasan_slab_free+0x106/0x190
   __kmem_cache_free+0x133/0x270
   svc_xprt_free+0x1e2/0x350 [sunrpc]
   svc_xprt_destroy_all+0x25a/0x440 [sunrpc]
   nfsd_put+0x125/0x240 [nfsd]
   nfsd_svc+0x2cb/0x3c0 [nfsd]
   write_threads+0x1ac/0x2a0 [nfsd]
   nfsctl_transaction_write+0xac/0x110 [nfsd]
   vfs_write+0x1c3/0xae0
   ksys_write+0xed/0x1c0
   do_syscall_64+0x38/0x90
   entry_SYSCALL_64_after_hwframe+0x72/0xdc

Fix the UAF by simply doing nothing in svc_tcp_listen_data_ready()
if state != TCP_LISTEN, that will avoid dereferencing svsk for all
child socket.

Link: https://lore.kernel.org/lkml/20230507091131.23540-1-dinghui@sangfor.com.cn/
Fixes: fa9251a ("SUNRPC: Call the default socket callbacks instead of open coding")
Signed-off-by: Ding Hui <dinghui@sangfor.com.cn>
Cc: <stable@vger.kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rweight rweight

@fpgamatt fpgamatt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@rweight @208yunyao @isaacncz @ronyschutzInt @fpgamatt @chipb-intel