Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential improvements on Parameters subtypes #65

Open
JordiBolibar opened this issue Sep 19, 2022 · 4 comments
Open

Potential improvements on Parameters subtypes #65

JordiBolibar opened this issue Sep 19, 2022 · 4 comments
Labels
enhancement New feature or request
Milestone
Second ODINN release

Comments

@JordiBolibar
Copy link
Member

Instead of having them as a stack of global parameters, gather them in a data structure (struct or Dict) in order to tidy things up.
@JordiBolibar JordiBolibar added the enhancement New feature or request label Sep 19, 2022
@JordiBolibar
Copy link
Member Author

An interesting alternative could be to use GeoParams.jl: https://github.com/JuliaGeodynamics/GeoParams.jl

@JordiBolibar
Copy link
Member Author

Another easier alternative would be to use: https://github.com/mauro3/Parameters.jl

@JordiBolibar JordiBolibar mentioned this issue Nov 25, 2022
Open
@JordiBolibar JordiBolibar added this to the Second ODINN release milestone Nov 25, 2022
@mauro3
Copy link

mauro3 commented Apr 30, 2023

Do note that @kwdef is now exported in Julia 1.9 (and thus officially supported), so maybe that is enough? (can also be used in 1.8 via Base.@kwdef.

@JordiBolibar
Copy link
Member Author

Yep, I've started the design of the new API and @kwdef is so far enough for me. Cool package!

@JordiBolibar JordiBolibar changed the title Create parameters structure based on parameters.jl Potential improvements on Parameters subtypes Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Second ODINN release
Development

No branches or pull requests
2 participants
@JordiBolibar @mauro3