[FIX] web_responsive: Missing key in search panel filter component OWL #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idenayer
force-pushed
the
16.0
branch
3 times, most recently
from
7dd0da5
to
b086071
Compare
Fixes OCA#2653 Owl requires the presence of a t-key directive in [t-foreach](https://github.com/odoo/owl/blob/master/doc/reference/templates.md#loops) to be able to properly reconcile renderings. The owl template in `web_responsive/static/src/components/search_panel/search_panel.xml` missed the t-key directive. Hence the crash. This commit introduces this `t-key` and ensures that it is unique.
|
@yajo if you have time to have a look at the following PR. that would be great. |
|
Sorry, I'm no longer maintaining this. I forgot to quit before. See #2696. |
|
Hello @Tardo, do you have the time to review this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2653
Owl requires the presence of a t-key directive in t-foreach to be able to properly reconcile renderings.
The owl template in
web_responsive/static/src/components/search_panel/search_panel.xmlmissed the t-key directive. Hence the crash.This commit introduces this
t-keyand ensures that it is unique.