Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] web_notify_channel_message raising exception for non admin users #2620

Open
remi-filament opened this issue Sep 25, 2023 · 2 comments
Labels

Comments

@remi-filament
Copy link
Contributor

Module

web_notify_channel_message

Describe the bug

With this module installed a non admin user cannot send message on channels anymore, you get the following exception:
image

To Reproduce

Affected versions: 14.0, but the same occurs in #2542 for v15 and #2543 for v16

Steps to reproduce the behavior:

  1. Install web_notify_channel_message or open v14.0 runboat (or one of the above PR runboat)
  2. Connect with non admin user (for instance demo/demo)
  3. Try sending a message on general channel
  4. your get the above exception

Expected behavior
Users should still be able to post on general channels and everyone from channel should be notified.

@remi-filament
Copy link
Contributor Author

ping @JordiBForgeFlow since you contributed the module
Thanks !

@DavidJForgeFlow
Copy link
Contributor

Hi @remi-filament , check the following PRs that fixes this issues:
#2673 & #2674.
If this PRs are approved I will forward port to next versions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants