Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] Can't use base_fontawesome, not showing icons #2694

Open
iggups opened this issue Aug 10, 2023 · 5 comments
Open

[16.0] Can't use base_fontawesome, not showing icons #2694

iggups opened this issue Aug 10, 2023 · 5 comments
Labels

Comments

@iggups
Copy link

iggups commented Aug 10, 2023

Module

base_fontawesome

Describe the bug

Tried to use the new icons in an XML view but I don't see any icon at all. Maybe I am using it wrong? I followed the documentation.

To Reproduce

Affected versions: 16.0.5.15.4

Steps to reproduce the behavior:

  1. Install module
  2. Add <button brand_icon="fa-amazon-pay" string=" fa-amazon-pay"/> to a form view
  3. Only string is shown, no icon

Expected behavior
Icon is shown

@iggups iggups added the bug label Aug 10, 2023
@danielduqma
Copy link
Contributor

Found similar bug, an easy way to reproduce is installing just base_fontawesome and website on a clean installation, for example on runboat. Tested on linked runboat and right after installation icons of social networks on footer are broken:

image

Looks like not all assets are loaded:

image

Could anyone take a look of this please @OCA/tools-maintainers?

Best regards.

@thomaspaulb
Copy link
Contributor

It seems to be something amiss in web.assets_frontend.

When inspecting /web/assets/debug/1/web.assets_frontend.css on Runboat, fontawesome.css is included, but all.css isn't, and I think that's the one needed for the correct interpretation of the fa-* classes. In the backend, it does work.

@danielduqma
Copy link
Contributor

Solved in #2740, could someone take a look please? Thanks!

@iggups
Copy link
Author

iggups commented Dec 29, 2023

Hi folks,
I am still not seeing the icons in the odoo backend. I am using them as described in the OP.

I updated the module to 16.0.5.16.0 and wanted to use the new icons in a form view button like:

<button class="oe_stat_button" type="object" name="action_foobar" brand_icon="fa-amazon-pay">
   <field name="foobar_count" widget="statinfo" string="Foo Bar"/>
</button>

@thomaspaulb
Copy link
Contributor

@iggups I think it is now fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants