Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old values are alwasy false #2634

Open
mads-vkd opened this issue May 30, 2023 · 1 comment
Open

Old values are alwasy false #2634

mads-vkd opened this issue May 30, 2023 · 1 comment

Comments

@mads-vkd
Copy link

old_values = dict((id_, old_vals2) for id_ in self.ids)

We're encountering an issue where the "old value" is always false; is that the intended logic here? It would seem it simply takes the key values from the vals dictionary and creates a dictionary where the values of each key is simply False, without populating them with the current values found on "self" prior to writing to the recordset.
It has the knock-on effect of rendering the logging of any field that is edited to be False as invisible, as the code sees the old and new value as the same (False), and thus doesn't add any line to the resulting log, only showing something was edited, but not what, nor to what.

@BT-srieskamp
Copy link

@mads-vkd To me it also does not seem to be correct as the deletion of a value within a product field is not tracked properly. not sure if this issue goes into the same direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants