Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Docs are not removed correctly #7

Open
MrDevel0per opened this issue Dec 18, 2023 · 0 comments
Open

[BUG] Docs are not removed correctly #7

MrDevel0per opened this issue Dec 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@MrDevel0per
Copy link
Contributor

Describe the bug
When one runs ally remove on an alias with documentation added on the lines above, these lines of documentation are not properly removed; instead, they remain and are then incorrectly interpreted as docs for other commands.

Output
First, create a sample .ally file:

# This is example documentation
alias example="echo Hello, World\!"
alias testTwo="echo TestTwo"

Now, run ally remove:

ally remove example
.Ally file has been resaved, and example is no longer available in the .ally file. To make these settings take effect for this terminal session, run
source ~/.ally

However, if one now executes ally list or looks at the contents of the ~/.ally file:

# This is example documentation
alias testTwo="echo TestTwo"

The alias is removed, but its docs were not.

To Reproduce
Steps to reproduce the behavior:

  1. Add commands with docs to .ally file.
  2. Execute ally remove ALIAS_WITH_DOCUMENTATION
  3. Run ally list or cat ~/.ally
  4. See that docs for removed command still remain, and are incorrectly attributed to other commands.

Expected behavior
The documentation should have been removed with the command when ally remove was run, leaving no docs left for the removed command.

@MrDevel0per MrDevel0per added the bug Something isn't working label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant