Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix install script alias #5

Open
MrDevel0per opened this issue Nov 24, 2023 · 0 comments
Open

[BUG] Fix install script alias #5

MrDevel0per opened this issue Nov 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@MrDevel0per
Copy link
Contributor

Describe the bug
macOS automatically adds binaries in /usr/bin to PATH. Our install.sh script moves our built ally binary to that location - thus, the first line of the ally file ends up being:

alias ally="ally"

We should either fix this alias (i.e. not add it) or add an option to not add it or install in a different location.

Output

alias ally="ally"

THIS IS EXPECTED BEHAVIOR. This is also desired, as if the user installs in a location not on PATH, then we want this alias. We could fix it:

FIX
One, allow the user to specify --no-alias and also --overwrite (the second one is unrelated to this issue, but still good-to-have) when installing. Specify this --no-alias when calling ally init (which we might want to change to ally setup) from the script.

@MrDevel0per MrDevel0per added the bug Something isn't working label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant