Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Add support for windows 11 mica blur #209

Open
SupertigerDev opened this issue Nov 6, 2021 · 8 comments
Open

Add support for windows 11 mica blur #209

SupertigerDev opened this issue Nov 6, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@SupertigerDev
Copy link

Add support for the new Mica effect. Someone has already made it work for flutter and i was wondering if it could be added.

repo: https://github.com/alexmercerind/flutter_acrylic

Thanks.

@SupertigerDev SupertigerDev added the enhancement New feature or request label Nov 6, 2021
@NyaomiDEV
Copy link
Owner

Electron itself is already adding Mica blur support natively. I think that is just better to wait until they do it officially; but if someone wants to PR it to Glasstron, I will be glad to review and merge the implementation. Sadly, I am not that much of a C bindings developer so I really cannot do it by myself.

@SupertigerDev
Copy link
Author

Ooh that's cool, didn't know that. Thanks for the information!

@ghost
Copy link

ghost commented Nov 25, 2021

Electron itself is already adding Mica blur support natively. I think that is just better to wait until they do it officially; but if someone wants to PR it to Glasstron, I will be glad to review and merge the implementation. Sadly, I am not that much of a C bindings developer so I really cannot do it by myself.

I didnt know electron was doing mica but not acrylic, where have you found this info?

@NyaomiDEV
Copy link
Owner

NyaomiDEV commented Nov 25, 2021

I didnt know electron was doing mica but not acrylic, where have you found this info?

electron/electron#30298

@XFaonAE I mean, this obliterates the need of Glasstron!
And actually this PR should do both or at least Mica once it is finished

@ghost
Copy link

ghost commented Nov 26, 2021

Oh wow, they even have a pull request. Thanks for telling me!

@ghost
Copy link

ghost commented Dec 2, 2021

No one seems to be looking at the issue, the pending reveiwvers have ben pending for quite a while now

@NyaomiDEV
Copy link
Owner

No one seems to be looking at the issue, the pending reveiwvers have ben pending for quite a while now

In the grand scheme of things that PR is almost irrelevant to Electron developers. It will get reviewed at some point, though it is not a major issue at all. Electron has other stuff that actually concerns usability going on. That's at least my view about it.

@ghost
Copy link

ghost commented Dec 5, 2021

Oh ok

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants