Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data project peer feedback - CCC #5

Open
christianhojsgaard opened this issue Apr 21, 2024 · 0 comments
Open

Data project peer feedback - CCC #5

christianhojsgaard opened this issue Apr 21, 2024 · 0 comments

Comments

@christianhojsgaard
Copy link

The most elegant solution in the project was: (explain what and why)
Your graphs are really well done and indicates you have used time on figuring out the best way to present the results. Interactive plot nice addition.

The hardest section of code in the project to understand was: (explain what)
All you code is well explained.

This part of the project could be better documented: (explain what)
You explain what you are doing well and makes it easy to understand what you are trying to show with efficient frontier.

An idea for an improvement/clarification could be: (explain what and why)
Cannot think of any improvement to your project, both code and text are well formulated.

An idea for an extension could be: (explain what and why)
Have none.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant