Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback from Sarah and Pernille #3

Open
knw498 opened this issue Apr 21, 2024 · 0 comments
Open

Feedback from Sarah and Pernille #3

knw498 opened this issue Apr 21, 2024 · 0 comments

Comments

@knw498
Copy link

knw498 commented Apr 21, 2024

The most elegant solution in the project was:
We really like the interactive plot. Remember you can't see the plot in github, so maybe you could describe what you can see when you drag the slider.

The hardest section of code in the project to understand was:
We think you describe it well and there are therefore no parts we think are more difficult to understand. It seems clear that you are very good at Python.

This part of the project could be better documented:
We think you document a lot. We don't think there are any places where it is necessary to describe further. You describe the procedure well and make a good introduction and conclusion.

An idea for an improvement/clarification could be:
We would prefer the description of figures to be below the figure and not before the code as you have done now.

An idea for an extension could be:
Perhaps you could start by showing how your dataset originally looked before you did anything to it. But maybe that's unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant