Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Feedback - CCC #2

Open
christianhojsgaard opened this issue Mar 31, 2024 · 0 comments
Open

Peer Feedback - CCC #2

christianhojsgaard opened this issue Mar 31, 2024 · 0 comments

Comments

@christianhojsgaard
Copy link

christianhojsgaard commented Mar 31, 2024

  1. The most elegant solution in the project was: (explain what and why)

Overall I must say, that you very nicely go through the project and code (especially question 1-3), which makes it easy to understand - it that way, elegant throughout. In particular, question 6b is well done with the graph.

  1. The hardest section of code in the project to understand was: (explain what)

I actually did not struggle with any specific part, as I think you helped the reader a lot. The code is split in to appropriate pieces/sections.

  1. This part of the project could be better documented: (explain what)

No comment on this, as I find all to be well documented.

  1. An idea for an improvement/clarification could be: (explain what and why)

Your graphs in general could maybe have used a bit more of "playing around" with the settings, as I think you could have had better looking graphs.

  1. An idea for an extension could be: (explain what and why)

Continued with the text you had in questions 1-3 would have been nice, but I think all in all very nice project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant