feedback - dataproject

[darja2502]

1. The most elegant solution in the project was:

Using an additional python file to summarize your functions in it avoids that your jupyter file is too "crowded". You also commented it nicely out there by using triple quotes such that it is understandable what you did.
Additionally, I like that you imported the data using APIs - allowing your folder not be filled by all the data frames.

2. The hardest section of code in the project to understand was:

In general, I believe that your project is good to follow. So, I didn't have any problems understanding anything.

3. This part of the project could be better documented:

I saw that you have some introduction part about your project in the corresponding README. However, I believe it would be good to have some kind of introduction also in the jupyter file because you jump directly in the project by importing the packages etc in the jupyter file. You can just copy & paste the part from the README to make it clearer to the reader of the jupyter file what you did.

4. An idea for an improvement/clarification could be:

You can delete the unnecessary csv files in your folder (dataX.csv, dataY.csv) just to clean your folder a bit. I don't really understand why you have additional saved graphics of your plots in the folder? Running your code, produces the plots already. So, you can delete the saved graphics there, too.

Step 1a is explained in Danish in the jupyter file by you- you should change that to English, too.

5. An idea for an extension could be:

You could look at the situation in other countries compared to Denmark. But maybe that goes beyond the scope of this project..