Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Feedback - Data Project #6

Open
sgp378 opened this issue Apr 21, 2024 · 0 comments
Open

Peer Feedback - Data Project #6

sgp378 opened this issue Apr 21, 2024 · 0 comments

Comments

@sgp378
Copy link

sgp378 commented Apr 21, 2024

  1. The most elegant solution in the project was: (explain what and why)
    The most elegant solution is your last two graphs, though you should give your figures numbers and titles. But the last two graph are good looking.

  2. The hardest section of code in the project to understand was: (explain what)
    In general your code is simple and easy to understand because you have made lines with text that explains it all. Therefore as later pointed out you could see if it is possible to make an API that downloads the data. This could take your code to the next level.

  3. This part of the project could be better documented: (explain what)
    The first two graphs is a bit difficult to understand why you make those and what they should tell/show us?

  4. An idea for an improvement/clarification could be: (explain what and why)
    When looking at and cleaning the data, it is pretty hard to see what the tables contain. Some values says NaN and other places the values are given in e^5 and so on. You could maybe focus a bit on making theese tables, and thereby the data, more readable.

  5. An idea for an extension could be: (explain what and why)
    You could use an API to download the data from Worldbank and Statbank directly into your project, so that when new data comes it can download that too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant