Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer feedback for data project 2024 #5

Open
AntonEbsen opened this issue Apr 19, 2024 · 0 comments
Open

Peer feedback for data project 2024 #5

AntonEbsen opened this issue Apr 19, 2024 · 0 comments

Comments

@AntonEbsen
Copy link

Dear Darja and Christian,
Overall, we are very impressed by your data project, and, therefore, we have few ideas for improvement.

1. The most elegant solution in the project was: (explain what and why)

  • The scatterplot is beautiful and makes it easier to get an overview of the EU-countries debt and Average annual GDP growth.
  • Also, a it is a very interesting topic you analyze.
  • Your project is also very well structured with some of your code being in the . This is elegant, as us users can examine your results without getting into the details of your coding.

2. The hardest section of code in the project to understand was: (explain what)

  • It is hard to understand why you include so many summary statistics tables in your project, as you do not describe them that much.

3. This part of the project could be better documented: (explain what)

  • It is a great project. The only place that might need better documentation is the summary statistic.

4. An idea for an improvement/clarification could be: (explain what and why)

  • It might be a good idea to cut down on the summary statistics or give an explanation for why the summaries are relevant in long format or what visual impact it shows.
  • Also, it would be visually pleasing if you round your decimals to like two decimals for example in your tables. This would make it easier for the user to examine the tables you provide.
  • In your interactive times plot it would be nice if you could use Thousands separator for debt for the countries.

5. An idea for an extension could be: (explain what and why)

  • Maybe show a figure for average annual growth and average debt separately. Just to give a better overview for your project.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant