Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Feedback - Inaugural project #4

Open
sgp378 opened this issue Mar 31, 2024 · 0 comments
Open

Peer Feedback - Inaugural project #4

sgp378 opened this issue Mar 31, 2024 · 0 comments

Comments

@sgp378
Copy link

sgp378 commented Mar 31, 2024

1. The most elegant solution in the project was: (explain what and why)
The Exchange economy file is clean and easy to read.
The most elegant presentation of your results is your answer to question 6b. The fact that you use the results from question 1 and then plots all the other results you have found makes it very easy to compare. Good job using your previous code to make this clean graph.

2. The hardest section of code in the project to understand was: (explain what)
I don't like that you have multiple .ipynb files. That is a bit confusing and i think you should just have 1 (though it seems like u have collected the other 2 ipynb files into the third. Other than that i find it easy to understand all your code, or at least i can quickly read how it works if i am in doubt.

3. This part of the project could be better documented: (explain what)
I think you could explain more why you use certain code or what the codes you use does. This is not very important but the only thing i could think of that would make it easier to understand and make people able to quickly read and change the code if neccesary.

4. An idea for an improvement/clarification could be: (explain what and why)
Your output in question 2 is a bit confusing and your code seems very long. Maybe you could shorten this code and improve the visual of your output here. I know we wrote this code in just a couple of lines and made an easy to read tabel.

5. An idea for an extension could be: (explain what and why)
1 improvement could be changin the axis titles in graph 1, so that it explains what we see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant