Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer feedback #1

Open
laug030 opened this issue Mar 30, 2024 · 0 comments
Open

Peer feedback #1

laug030 opened this issue Mar 30, 2024 · 0 comments

Comments

@laug030
Copy link

laug030 commented Mar 30, 2024

The most elegant solution in the project was: (explain what and why)
The most elegant solution in the project was the Edgeworth Box-representation of all optimization problems in Exercise 6b. The authors have throughout the exercises saved the optimal allocations under names that they call in this exercise and represent it within the Pareto Optimal figure from Exercise 1, which clearly shows how all the exercises provide Pareto Optimal solutions where nobody is worse off than in their initial endowment.

The hardest section of code in the project to understand was: (explain what)
Your hand-in is thorough and reasonanbly documented, so there is nothing in particular that we are unable to understand without studying the documentation and using the debugger.
This part of the project could be better documented: (explain what)
In general, the notebook could benefit from more detailed documentation, especially regarding the purpose and usage of specific imports and instances. Comments explaining the reasoning behind certain code decisions (like the specific matplotlib settings) would enhance understanding.
An idea for an improvement/clarification could be: (explain what and why)D
In question 3, it is not thoroughly described why the market clearing price is found where the two error graphs intersect - this could be described more thoroughly. Also, you could describe better why the error graphs look as they do - why is one linearly increasing and the other is exponentially decreasing?

An idea for an extension could be: (explain what and why)
In the figure in Exercise 1, you could include axis-titles and numbers to clarify that we’re in an Edgeworth Box with total endowment equal to 1 for each good. It is not super clear which axes are showing consumption for person A or B.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant