You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. The most elegant solution in the project was:
In general, the way you have incorporated classes is done very nicely. The code here is pretty compact and efficient, without many unnecessary steps. In addition, this makes the project easier to read, since much of the more complex code is in the py file.
2. The hardest section of code in the project to understand was:
The simulation part, especially the ‘simulate_before_s’ and ‘simulate_after_s’ functions can be pretty hard to understand, maybe these functions could benefit from some more explanations in the beginning, describing what the code does.
3. This part of the project could be better documented:
In general, the code in the py.file could be better documented, especially the simulation codes as mentioned previously.
4. An idea for an improvement/clarification could be:
Since your code for all of your figures are pretty similar, you could create a function for them too in your py.file. This would make your project even easier to read and understand.
5. An idea for an extension could be:
Your figures are all visually appealing and easy to understand. A way to improve them could be by making interactive plots for the different parameter values. In this way one figure would be enough to come across with your conclusions and you could show how your results change with even more values for the parameters. Otherwise you have done a really good job with the project!
The text was updated successfully, but these errors were encountered:
1. The most elegant solution in the project was:
In general, the way you have incorporated classes is done very nicely. The code here is pretty compact and efficient, without many unnecessary steps. In addition, this makes the project easier to read, since much of the more complex code is in the py file.
2. The hardest section of code in the project to understand was:
The simulation part, especially the ‘simulate_before_s’ and ‘simulate_after_s’ functions can be pretty hard to understand, maybe these functions could benefit from some more explanations in the beginning, describing what the code does.
3. This part of the project could be better documented:
In general, the code in the py.file could be better documented, especially the simulation codes as mentioned previously.
4. An idea for an improvement/clarification could be:
Since your code for all of your figures are pretty similar, you could create a function for them too in your py.file. This would make your project even easier to read and understand.
5. An idea for an extension could be:
Your figures are all visually appealing and easy to understand. A way to improve them could be by making interactive plots for the different parameter values. In this way one figure would be enough to come across with your conclusions and you could show how your results change with even more values for the parameters. Otherwise you have done a really good job with the project!
The text was updated successfully, but these errors were encountered: