Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4. An idea for an improvement/clarification could be: (explain what and why) #4

Open
fpv111 opened this issue Mar 28, 2024 · 2 comments

Comments

@fpv111
Copy link

fpv111 commented Mar 28, 2024

I think you should improve the printed results. Instead of just printing " (x1A,x2A) = (0.3334, 0.6666) -> uA = 0.5291". You could print something like "The optimal allocation is x1A = 0.33 and x2A = 0.66 which yields a utility of uA = 0.52". I think you should do something like this in all of your results. E.g in Q3 where you just print 3 numbers and don't show, what they are equal to.

I also think you can improve your code, by making more comments on what/why you do it. It is quit hard to understand your code sometimes.

In the last question where you use the Exchange Economy Class, I think you should insert the code into the other py file. Otherwise, your code gets very long.
In the last question, I also think that you should improve your graph. I don't know what unit is on the axis, and I don't know what the graph shows.

@drp193
Copy link

drp193 commented Mar 29, 2024

As mentioned before, clarifying what the printed results represent would improve the project. Moreover, writing more of the code in the model .py file and referencing to the .py file would reduce the amount of code in the results notebook, in turn creating an easier to read project. Something such as defining the loops in the .py file, and the printing the results directly from the .py file.

As mentioned before, add a few markdown lines explaining what's being answered and how the code functions. I think you can remove a lot of text from the code lines by doing so.

Lastly, adding an edgeworth box for Q1 and defining axis labels in Q8.

@Jiyunkimmm
Copy link

As I mentioned in point 1, you should improve your graph on question8, by adding what x-axis and y-axis are.
And also it would be nice if you arrange the answer of question 7 : it is sometimes hard to get the information at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants