Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3. This part of the project could be better documented: (explain what) #3

Open
fpv111 opened this issue Mar 28, 2024 · 2 comments
Open

Comments

@fpv111
Copy link

fpv111 commented Mar 28, 2024

When I run Q1, I don't get an Edgeworth box. Perhaps something is wrong with your code?

In Q4 you just write the results, but your code does not print any results. I don't believe, that you are allowed to do that.

Again in Q5B, I don't understand the printed result. You should remove the part, that is not important.

In Q6b you should make a code, that shows the different results.

I get an error, when I try to run Q8.

@drp193
Copy link

drp193 commented Mar 29, 2024

Other than the error in Q8, Q1 is missing and edgeworth box. Furthermore, you could add a markdown line before every answer, briefly explaining what the code does and what you're trying to answer. This would make the results easier to understand and add better workflow to the overall project. Generally, you could improve the overall flow by having more clear and concise printed results. For example, in Q4a the answer is just written in the code, and in Q4b you could add a statement such that the result printed is something such as:
"p = 1.927, uA = 0.634".

@Jiyunkimmm
Copy link

As drp193 mentioned, it would be greater if you add a statement which number belongs to the result, for example p = 0 .
And I still find the statement like Explain your code and procedure. You can improve your codes and results by checking these statements again !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants