Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Feedback: Data Project #3

Open
Lennings1 opened this issue Apr 23, 2024 · 0 comments
Open

Peer Feedback: Data Project #3

Lennings1 opened this issue Apr 23, 2024 · 0 comments

Comments

@Lennings1
Copy link

The most elegant solution in the project was:
Your decision to use the 'GraphHelper' class for plotting is a nice way to handle visualizations. It keeps your main script cleaner and focuses more on the analysis rather than the plotting. It’s a good practice, especially for a data-heavy analysis like this one.

The hardest section of code in the project to understand was:
The section where you merge data from different countries and try to compare their inflation and unemployment could use a bit more explanation. It's a complex task, and while you handle it well technically.

This part of the project could be better documented:
The process of getting data through 'DataHelper' and what exactly this class is doing would benefit from more documentation. Since fetching and handling data is critical in your project, making sure everyone understands how data is being manipulated behind the scenes is important.

An idea for an improvement/clarification could be:
In your visualizations, especially those comparing multiple countries, adding interactive elements like tooltips or a legend that dynamically updates could make it easier for the reader. This would make it easier to understand the data points without having to refer back to the text for context.

An idea for an extension could be:
Considering exploring other economic factors that might influence or be influenced by the Phillips Curve, such as GDP growth, interest rates, or policy changes. This could add depth to your analysis and possibly explain more about the dynamics between these variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant