Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer feedback from Andreas_and_Mangus on the data project #6

Closed
AndreasTroglauer opened this issue Apr 20, 2024 · 0 comments
Closed

Comments

@AndreasTroglauer
Copy link

Firstly, a very nice project

  1. The most elegant solution in the project was: (explain what and why)
  • We really like the text in the assignment. it is clearly explained what you are investigating, and the structure is very clear.
  1. The hardest section of code in the project to understand was: (explain what)
  • We had trouble knowing what .py files that needed to be loaded. in your read.me file, you have only stated that the project can be seen by running the notebook, yet in the notebook you draw from a .py file - så maybe update the readme file :) but reading the notebook, it is clear which py files who needs to be runned :)
  1. This part of the project could be better documented: (explain what)
  • overall the projects are well documented, but perhabs you could explain the figure in 1.2, what it is showing.
  1. An idea for an improvement/clarification could be: (explain what and why)
  • I have 1 small things who I think could be improved:
  1. The read.me file, state which files who should be loaded, so the notebook can be read by one click
  2. An idea for an extension could be: (explain what and why)
  • I really think you covered everything, very nice to read :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants