Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer feedback from group Andy-and-birdy #4

Closed
htq483 opened this issue Apr 16, 2024 · 0 comments
Closed

Peer feedback from group Andy-and-birdy #4

htq483 opened this issue Apr 16, 2024 · 0 comments

Comments

@htq483
Copy link

htq483 commented Apr 16, 2024

Over all we think that this is a brilliant project. Your overall idea is rather complex but you most certainly answer your question and use the tools we have learned in class. To this we want to add that your code ran smoothly and fast.

The most elegant solution in the project was:

The cleaning process. You have defined cleaning functions in your .py file which you use to clean the data you have fetched and this removes a lot of code from the text and makes the code look very clean.

The hardest section of code in the project to understand was:

We think that the hardest part to under stand was the making of Interactive plot of development of amount of international employees for all sub-industries in the service sector. We could really under stand how it worked, and it also looked a bit weird when first loaded but made more sense when you chose a subindustry. We see that you yourself mentioned that it is AI generated why it may look weird given the things we have done in class

This part of the project could be better documented:

We think you have documented everything extremely well. Both writing notes around your code and explaining what you want to do and what your results show. You could write more in your functions in the .py file.

An idea for an improvement/clarification could be:

The last graph is somewhat hard to read, as the legends lay above the graph, at least when we run the code. This you may could look into.

An idea for an extension could be:

Conclude more on your summary statistics, and maybe display the results so you get a good overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants