Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer feedback #3

Closed
snd950 opened this issue Mar 31, 2024 · 0 comments
Closed

Peer feedback #3

snd950 opened this issue Mar 31, 2024 · 0 comments

Comments

@snd950
Copy link

snd950 commented Mar 31, 2024

1. Most elegant solution: I really like your solution to Question 3 where you find the market clearing price. Your comments and descriptions are nice and the answer looks correct as well.

2. Hardest section of code to understand: The hardest section of the code to understand is Question 5A. It is a complicated code, so you could add more comments to this section to make it easier to understand.

3. Part that could be better documented: You could document Question 7 with a graph that illustrates the random draws. Generally the assignment feels more complete when every answer is documented with a graph.

4. Idea for improvement: It looks like your Question 1 figure is incorrect. It should be formed like an cigar, so you should revisit this answer.

5. Idea for extension: In Question 6B you could add a graph that includes all the allocations that you found in the assignment, so it is easier to compare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants