Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colormgr should change more terminal text colors #151

Open
ghost opened this issue May 3, 2023 · 1 comment
Open

Colormgr should change more terminal text colors #151

ghost opened this issue May 3, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 3, 2023

Currently NsCDE's colormgr only themes the default foreground text color and the background. This leads to the other colors (1-7) sometimes becoming unreadable.

What dtterm does[1] is use extremely simple colors:

0: #000000 (black)
1: #ff0000 (red)
2: #00ff00 (green)
3: #ffff00 (yellow)
4: #0000ff (blue)
5: #ff00ff (magenta)
6: #00ffff (cyan)
7: #ffffff (white)

It uses these same colors for all the color palettes. Cycling through the color palettes provided shows all of them work ok, with the exception of yellow not looking very readable on light backgrounds. For intense and faint (1;31/2;31 instead of 0;31) it simply bolds the text. Not sure about other terminals but Konsole has an option to bold intense text but not faint text.

Ideally there would be some sort of library like 'generate a color scheme based on this background color' but I can't seem to find any (maybe someone here knows of one). Until then it should probably just change them to the 7 dtterm colors, possibly with something like 10% darker/lighter for bold/faint.

[1] Testing using this https://archive.org/details/solaris265-qemu

@NsCDE
Copy link
Owner

NsCDE commented May 6, 2023

Hello @tim78245

Thanks for providing me this information. Also, you have retinhed problem rightly. I didn't got into dtterm colors deep never, and coloring things in terminal programatically on the basis of the terminal background (palette color 4) is outside CDE scope and risky.

I'm not sure about faint color, but bold for intense is a logical choice, while 10-20% less saturated for faint will make sense.

Currently, colormgr.local may take a care about mate-terminal, konsole, qterminal, xfce-terminal and couple of this, but this is for terminal background and foreground, while colors are totally non-standard and non-uniformed.

Goes on the todo list ...

@NsCDE NsCDE self-assigned this May 6, 2023
@NsCDE NsCDE added the enhancement New feature or request label May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant