Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK theme regression? #148

Open
ghost opened this issue Apr 13, 2023 · 10 comments
Open

GTK theme regression? #148

ghost opened this issue Apr 13, 2023 · 10 comments
Assignees
Labels
bug Something isn't working Pending for more info Pending for more info TODO Things to implement

Comments

@ghost
Copy link

ghost commented Apr 13, 2023

I changed the NsCDE color for fun but then changed it back to my usual, Broica. Since then I've noticed some oddities.

For example in SeaMonkey mail the item rows alternate colors.
image

Before they used to be all purple. I've downgraded SeaMonkey to ensure the problem is with NsCDE rather than something SeaMonkey may have changed, same result, the issue is on NsCDE's side.

As well the chromium bar is now solid brown with no differences for the buttons or omnibar, and when clicking on the omnibar it becomes white.

@NsCDE
Copy link
Owner

NsCDE commented Apr 17, 2023

Hi @tim78245,

Which version of NsCDE and where your userChrome.css points out? It should be ok on Thunderbird.

EDIT:
Find the hex of the color and put at the bottom of your userChrome.css right version to override as a workaround in the meantime.

@ghost
Copy link
Author

ghost commented Apr 20, 2023

No userChrome.css is in use with SeaMonkey.

So I can verify it's a regression with NsCDE or at least Fedora's NsCDE, downgrading from NsCDE-2.2-2.fc37 to NsCDE-2.1-2.fc37 fixes the issue with both SeaMonkey and Chromium.

That being said I'm not sure why...

@ghost
Copy link
Author

ghost commented Apr 27, 2023

It has something to do with the change from gtk-3.20/widgets.css to gtk-3.20/widgets-*.css. Telling it to load the old widgets.css (adding @import url("widgets.css"); to gtk.css) ends up fixing the problem.

@NsCDE
Copy link
Owner

NsCDE commented Apr 28, 2023

Ok, thanks for the clue. Next month I will have time to find and fix this and some other issues for new release.

@NsCDE NsCDE self-assigned this Apr 29, 2023
@NsCDE NsCDE added the bug Something isn't working label Apr 29, 2023
@NsCDE
Copy link
Owner

NsCDE commented May 24, 2023

Hi @tim78245

I have tried SeaMonkey and to reproduce this problem, but mailbox list and mail list doesn't have odd and even rows colored differently at all. Altrough, there is a lot of work to fix some elements in userChrome.css to get it look right. Maybe you can try it, I must release 2.3 soon, because I will have lot of work till the holidays and will not be able to work on NsCDE till autumn.

I have tried Seamonkey 2.53.16 on openSUSE Tumbleweed.

@NsCDE NsCDE added the Pending for more info Pending for more info label May 24, 2023
@ghost
Copy link
Author

ghost commented May 28, 2023

Hi @tim78245

I have tried SeaMonkey and to reproduce this problem, but mailbox list and mail list doesn't have odd and even rows colored differently at all. Altrough, there is a lot of work to fix some elements in userChrome.css to get it look right. Maybe you can try it, I must release 2.3 soon, because I will have lot of work till the holidays and will not be able to work on NsCDE till autumn.

I have tried Seamonkey 2.53.16 on openSUSE Tumbleweed.

Same version of SeaMonkey but on Fedora. I ended up uninstalling Fedora's NsCDE, installing the official release RPM, reloading Broica in color manager, and the same issue applies. I also tried using the official SeaMonkey build instead of Fedora's and the issue also applies.

Strange to me that the behavior differs on openSUSE, are you using SeaMonkey's official build?.

@ghost
Copy link
Author

ghost commented Sep 8, 2023

Hi @tim78245

I have tried SeaMonkey and to reproduce this problem, but mailbox list and mail list doesn't have odd and even rows colored differently at all. Altrough, there is a lot of work to fix some elements in userChrome.css to get it look right. Maybe you can try it, I must release 2.3 soon, because I will have lot of work till the holidays and will not be able to work on NsCDE till autumn.

I have tried Seamonkey 2.53.16 on openSUSE Tumbleweed.

I tried it on openSUSE Tumbleweed and the issue is there as well, using both NsCDE from openSUSE's repos and NsCDE from the releases.

@ghost
Copy link
Author

ghost commented Sep 9, 2023

I managed to find the source of the problem.

80261da

Reverting *.view to bg_text/fg_text ends up fixing the problem.

That being said it might be too powerful. I'm not sure what exactly .view it's using. GTK_DEBUG=interactive is no help here as the whole thing is in MozContainer (which is unfortunately not CSS selectable otherwise MozContainer > *.view would be an easy fix). If we can't work around Seamonkey perhaps we can work around the application that was originally broken?

@NsCDE
Copy link
Owner

NsCDE commented Sep 9, 2023

Congratulations @tim78245 you found it.

However, this change fixes column headers in GTK open dialogs and in some other places. Now I will need to play with it to get better fix which will not clobber *.view in wrong places.

@NsCDE NsCDE added the TODO Things to implement label Sep 9, 2023
@ghost
Copy link
Author

ghost commented Sep 10, 2023

Congratulations @tim78245 you found it.

However, this change fixes column headers in GTK open dialogs and in some other places. Now I will need to play with it to get better fix which will not clobber *.view in wrong places.

I really don't know what you mean. When I change those two lines back there's no change to the file opener (1. open pluma 2. ctrl+o). Do you mean something else?

And your change clobbers *.view in a lot of places, like in caja's panels and in the mate-calculator "screen". I can only assume it breaks a lot more. I'm guessing you shouldn't have changed *.view, just the dialog .view's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Pending for more info Pending for more info TODO Things to implement
Projects
None yet
Development

No branches or pull requests

1 participant