Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CI run faster #439

Closed
fvictorio opened this issue May 8, 2024 · 3 comments · Fixed by #501
Closed

Make CI run faster #439

fvictorio opened this issue May 8, 2024 · 3 comments · Fixed by #501
Assignees

Comments

@fvictorio
Copy link
Member

The EDR workflow takes more than 25 minutes to run. We should check if there's room for improvement here.

One easy gain is to remove the dependency between the tests and the "Check EDR" job. That would save some minutes, and the only downside is that we "waste" some computing time by running the tests when the build/lint fails.

We should also consider taking the slowest tests and only running them in main or during pre-release.

@Wodann
Copy link
Collaborator

Wodann commented May 8, 2024

There might be a simpler fix for this. We set the Cargo profile for tests to be optimised, but this means that builds take longer. We should see whether this tradeoff is worth it in CI/locally.

@alcuadrado
Copy link
Member

I think the cache and solc changes in this PR can be extra relevant here: https://github.com/NomicFoundation/hardhat/pull/5184/files

@fvictorio fvictorio self-assigned this May 22, 2024
@Xanewok
Copy link
Contributor

Xanewok commented Jun 7, 2024

I already looked into streamlining and speeding up local workflow as part of my onboarding (e.g. #499), so I'll take a quick look with a fresh pair of eyes if there's anything we can do to get the best bang for the buck on the Rust/Cargo side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants