Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplicate hardfork activations info #335

Open
fvictorio opened this issue Mar 13, 2024 · 0 comments
Open

Deduplicate hardfork activations info #335

fvictorio opened this issue Mar 13, 2024 · 0 comments

Comments

@fvictorio
Copy link
Member

fvictorio commented Mar 13, 2024

Right now the hardfork activations info lives in two places:

  • In the default config of Hardhat (here)
  • In edr_eth (here)

We should remove this duplication without affecting the possibility of users configuring these values.

I'm not sure what's the right way to do this. Two ideas:

  • Hardhat doesn't pass this anymore unless the user configured something (and this is merged with the defaults in EDR)
  • Hardhat still has these defaults but it imports them from EDR (but this means having a "tiny", shared module, because we don't want to load the full EDR during initialization)

The first option is technically a breaking change, but it might be acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant