New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node_redis: WARNING: You passed "rediss" as protocol instead of the "redis" protocol! #1331
Comments
This comment has been minimized.
This comment has been minimized.
The message should indeed be updated but it seems like you somehow passed through a wrong protocol. Can you please show what you passed to |
I encountered the same issue. Then I realized the commit enabling |
When is the new release? I need this feature. |
@BridgeAR @stockholmux @Salakar friendly ping. Maybe a new release is needed for this warning. |
I ran into this issue. If look at the online repo, I see the statement block for rediss. However, when I examine my actual node_modules folder, the version says it's 2.8, however the createClient file does not have that rediss statement block. I fixed locally by pasting the rediss if statement into my local node modules and that worked. I'm not sure how the distributed version is different than what's shown online in the repo. |
Sorry, I just realized that 2.8.0 was released in 2017, not 2018, before the TLS support was added to master Here's where the node module came from: https://registry.npmjs.org/redis/-/redis-2.8.0.tgz Download it and look at createClient.js. The TLS code is missing |
Is there any major value to using the TLS support? |
I've love to have it today, it would let us talk to encrypted auth AWS ElasticCache |
@jasonamyers I had more success with https://github.com/luin/ioredis on this issue - but you need a cachecluster setup, with at rest encryption, transport encryption and a password. API's are similar. |
Hello can someone please advice when this is going into master and getting released? Having this issue and had to manually overwrite createClient.js in node_module. This issue has been opened for over a year. Can we push this out and allow TLS ? |
Currently, this section if (parsed.protocol && parsed.protocol !== 'redis:') {
console.warn('node_redis: WARNING: You passed "' + parsed.protocol.substring(0, parsed.protocol.length - 1) + '" as protocol instead of the "redis" protocol!');
} need to be replaced by if (parsed.protocol === 'rediss:') {
options.tls = options.tls || {};
} else if (parsed.protocol !== 'redis:') {
console.warn('node_redis: WARNING: You passed "' + parsed.protocol.substring(0, parsed.protocol.length - 1) + '" as protocol instead of the "redis" protocol!');
} in createClient.js inorder to get rediss:// support or you could try another way like shown below. var redis = require("redis");
var client = redis.createClient("redis://:password@host:port", {tls:{}}); By passing tls as empty object got my redis client got connected without any issue. @scriptonian this should also solve your issue by avoiding manual overwrite in createClient.js Please Note : |
thank you venkatesh, yes i had already made this change as coguy450 had suggested it in the comments. but i am surprised the team hasnt updated this. Its been over a year ! |
+1 |
is there a new version coming with this fix? |
Somebody wants to make a pull request to support the rediss:// url? |
@peterpoliwoda it seems to be already added in the master branch... 👍 |
Hm... yeah I see it’s in the repo but npm doesn’t install with the fix. The version number hasn’t changed so ‘npm install’ keeps the old build, like it had an old tarball in the archive. Thanks a ton @venkatesh-nadar! |
@BridgeAR Can we get a new release in npm please? |
This comment has been minimized.
This comment has been minimized.
Hey everyone, I've taken over as lead maintainer and have all the required access now 🎉 I've spent the last few days getting master ready for a release, and as of a few minutes ago I've just published v3.0.0 to NPM; https://github.com/NodeRedis/node-redis/releases/tag/v3.0.0 - which includes this change. Expect regular releases - my first priority at the moment is making this project more contributor friendly to ensure that the project lives and continues to grow and is not blocked by any singular person's time. To do this I'd like to grow a larger set of shallow contributors. With this I hope to mitigate the previous problem of the project needing updates but there being no-one who has the power to do so. I'm working through the following on this;
After that I'll be switching my attention to modernising (e.g. promises) & clearing technical debt in the Node Redis codebase. @BridgeAR has already done a boat load of stuff for this, if you're curious check out the WIP v4 branch and its changelog. |
node_redis: WARNING: You passed "rediss" as protocol instead of the "redis" protocol!
this warning is displayed because
rediss:
is checked butrediss
would be correct - Line 35The text was updated successfully, but these errors were encountered: