Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ayugram-desktop: init at 4.16.8 #307584

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

duvetfalling
Copy link

@duvetfalling duvetfalling commented Apr 28, 2024

Description of changes

This PR adds ayugram-desktop, a Telegram Desktop fork with extended functionality.
To avoid code duplication where is telegram-desktop: refactor commit that refactors a bit so mainProgram was an argument instead of variable.
Fixes #307398.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@duvetfalling
Copy link
Author

cc @NickCao

pkgs/by-name/ay/ayugram-desktop/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ay/ayugram-desktop/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ay/ayugram-desktop/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ay/ayugram-desktop/package.nix Outdated Show resolved Hide resolved
@NickCao
Copy link
Member

NickCao commented May 14, 2024

diff LGTM, please resolve the merge conflict.

@NickCao
Copy link
Member

NickCao commented May 14, 2024

And please make sure you are allowed to use the official telegram-desktop API key for this thirdparty client, or you should provide your own.

@duvetfalling
Copy link
Author

duvetfalling commented May 14, 2024

And please make sure you are allowed to use the official telegram-desktop API key for this thirdparty client, or you should provide your own.

64gram in nixpkgs uses default official keys from telegram-desktop. The issue and PRs [1] [2] doesn't mention it.
Official prebuilt packages, AUR and ALT Linux uses these API keys, would it be okay to use them? I used my own for now.

Make mainProgram to an argument instead of variable.
This adds flexibility for packaging Telegram Desktop forks.
Set API ID and hash in arguments.
@Aleksanaa
Copy link
Member

Official prebuilt AyuGram uses these API keys, would it be okay to use them? I used my own for now.

Would be better to ask them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: Ayugram Desktop
5 participants