Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: PR template points to wrong documentation #294384

Closed
lolbinarycat opened this issue Mar 9, 2024 · 2 comments 路 Fixed by #298333
Closed

Documentation: PR template points to wrong documentation #294384

lolbinarycat opened this issue Mar 9, 2024 · 2 comments 路 Fixed by #298333

Comments

@lolbinarycat
Copy link
Contributor

Problem

the PR template points to https://nixos.org/manual/nixpkgs/unstable/#reviewing-contributions-package-updates instead of
https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#reviewing-contributions


Add a 馃憤 reaction to issues you find important.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 23, 2024

#298333

I kindly ask you to just create the PR the next time with this really trivial change instead of creating an issue.

@lolbinarycat
Copy link
Contributor Author

it's only trivial if you have experience with how github works. i had no idea the template was controlled by a file within the repo and not some option in the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants