Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nix post-build hooks #463

Open
fricklerhandwerk opened this issue Mar 6, 2023 · 11 comments · May be fixed by #528
Open

Nix post-build hooks #463

fricklerhandwerk opened this issue Mar 6, 2023 · 11 comments · May be fixed by #528
Labels
good first issue guide Topics for a new guides

Comments

@fricklerhandwerk
Copy link
Collaborator

fricklerhandwerk commented Mar 6, 2023 •
edited

Migrate post-build-hook guide to nix.dev. This is a valuable guide that doesn't belong to the Nix reference manual, but should absolutely be preserved and maintained.

More information: NixOS/nix#7979

Note: This is currently blocked on license incompatibility of LGPL and CC-BY-SA.

Blocked by: #478
@fricklerhandwerk fricklerhandwerk added the guide Topics for a new guides label Mar 6, 2023
This was referenced Mar 6, 2023
Draft
Open
@fricklerhandwerk
Copy link
Collaborator Author

fricklerhandwerk commented Mar 22, 2023 •
edited

The goal is to be able to present and maintain different types of documentation the appropriate contexts. One of the measures is to move that article to nix.dev, which requires re-licensing it.

@edolstra @grahamc @endgame @expipiplus1 @thufschmitt @kevinastock according to commit history here and here you are co-authors and therefore copyright holders of that document. Would you agree to re-license it to CC-BY-SA 4.0?

Background:
There was early consensus (mid 2022) for moving in the direction of more cleanly separating documentation types and thus moving things around. November 2022 was another docs team meeting that solidified that understanding. In December 2022 the Nix team merged a change that refers to the Nix Reference Manual, which reflects that agreement across teams.

Edit: Or is re-licensing redundant if we can just refer to the original license in place?

@endgame
Copy link

endgame commented Mar 22, 2023

Happy to re-licence but my changes are absolutely trivial. They're only a handful of lines and even GNU would accept changes of that size without copyright paperwork.

@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-03-21-documentation-team-meeting-notes-34/26619/1

@asymmetric
Copy link
Contributor

asymmetric commented Mar 23, 2023 •
edited

The file used to be named post-build-hook.xml:

❯ git log --pretty="%an" -- doc/manual/advanced-topics/post-build-hook.xml | sort | uniq
Eelco Dolstra
Graham Christensen
Joe Hermaszewski
Kevin Stock
regnat

@grahamc
Copy link
Member

grahamc commented Mar 23, 2023

and in @grahamc's case word of mouth

ref: NixOS/nix@7c55967

@grahamc
Copy link
Member

grahamc commented Mar 23, 2023

Note that I am ok with CC-BY-SA but I don't agree with transferring the ownership which is required for contributing it to this repo.

@fricklerhandwerk
Copy link
Collaborator Author

@grahamc Thanks! It looks like we'll remove the CLA soon: #478, I blocked this issue on that.

@thufschmitt
Copy link
Member

I'm fine with the re-licencing

@kevinastock
Copy link

My change is very minimal, but I'm happy to re-license and/or transfer ownership.

@expipiplus1
Copy link

No problem by me

fricklerhandwerk added a commit to fricklerhandwerk/nix.dev that referenced this issue May 4, 2023
@fricklerhandwerk @edolstra
@grahamc @expipiplus1 @kevinastock @endgame @thufschmitt
add guide on post build hook
adb335f 
originally written under LGPL 2.1 for the Nix reference manual.
authors as recorded in the Nix repository:

    git log --pretty="Co-authored-by: %an <%ae>" -- doc/manual/advanced-topics/post-build-hook.xml doc/manual/src/advanced-topics/post-build-hook.md | sort | uniq

relicenced with authors' permission to CC-BY-SA 4.0: NixOS#463

Co-authored-by: Eelco Dolstra <edolstra@gmail.com>
Co-authored-by: Graham Christensen <graham@grahamc.com>
Co-authored-by: Joe Hermaszewski <git@monoid.al>
Co-authored-by: Kevin Stock <kevin@kevinstock.org>
Co-authored-by: endgame <endgame@users.noreply.github.com>
Co-authored-by: regnat <rg@regnat.ovh>
@fricklerhandwerk fricklerhandwerk linked a pull request May 4, 2023 that will close this issue
Draft
@nixos-discourse
Copy link

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2023-10-19-documentation-team-meeting-notes-87/34349/5

@fricklerhandwerk fricklerhandwerk changed the title Migrate post-build-hook guide to nix.dev Nix post-build hooks Feb 7, 2024
@fricklerhandwerk fricklerhandwerk mentioned this issue Feb 7, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue guide Topics for a new guides
Projects
Nix documentation
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add guide on post build hook fricklerhandwerk/nix.dev
8 participants
@grahamc @asymmetric @kevinastock @endgame @expipiplus1 @fricklerhandwerk @thufschmitt @nixos-discourse