{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":29373791,"defaultBranch":"master","name":"parsetoml","ownerLogin":"NimParsers","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-01-17T00:13:30.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/39404291?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1691438161.0","currentOid":""},"activityList":{"items":[{"before":"cce7251fa2abc08301c1d4d320cb8745f0a38101","after":"f68ff54a69836f276ed267948a8637f845f39ec5","ref":"refs/heads/gh-pages","pushedAt":"2023-08-05T22:28:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: 6e5e16179fa2db60f2f37d8b1af4128aaa9c8aaf","shortMessageHtmlLink":"deploy: 6e5e161"}},{"before":"d0890980ab913e563600fc2f8a003c43eb087eb0","after":"6e5e16179fa2db60f2f37d8b1af4128aaa9c8aaf","ref":"refs/heads/master","pushedAt":"2023-08-05T22:28:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"PMunch","name":"Peter Munch-Ellingsen","path":"/PMunch","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2845482?s=80&v=4"},"commit":{"message":"Update parsetoml.nimble\n\nBump version to include latest fix for strictFuncs","shortMessageHtmlLink":"Update parsetoml.nimble"}},{"before":"6ea23f25d89d1b5b5f8d985cf9f0019d3b4ac56b","after":"cce7251fa2abc08301c1d4d320cb8745f0a38101","ref":"refs/heads/gh-pages","pushedAt":"2023-08-05T22:27:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: d0890980ab913e563600fc2f8a003c43eb087eb0","shortMessageHtmlLink":"deploy: d089098"}},{"before":"fef0e983ef7ecb5bb008e75ca61092376a31b130","after":"d0890980ab913e563600fc2f8a003c43eb087eb0","ref":"refs/heads/master","pushedAt":"2023-08-05T22:27:10.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"PMunch","name":"Peter Munch-Ellingsen","path":"/PMunch","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2845482?s=80&v=4"},"commit":{"message":"parsetoml: support compiling with strictFuncs again (#62)\n\nNim 1.6.0 added [1] an opt-in for the `strictEffects` behavior, which\r\nwill become the default in Nim 2.0 [2].\r\n\r\nParsetoml was changed to support compiling with strictEffects [3], but\r\nwe could no longer compile with strictFuncs:\r\n\r\n $ nim c --experimental:strictFuncs src/parsetoml.nim\r\n /tmp/parsetoml/src/parsetoml.nim(1742, 6) Error: '==' can have side effects\r\n > /tmp/parsetoml/src/parsetoml.nim(1769, 22) Hint: '==' calls `.sideEffect` '[]'\r\n >> /foo/nim-devel/lib/pure/collections/tables.nim(1851, 6) Hint: '[]' called by '=='\r\n\r\nAdd an override so that strictFuncs doesn't complain about the `func`.\r\nSimply changing the `func` to a `proc` doesn't work.\r\n\r\nNote that the definition of strictFuncs was recently changed [4].\r\n\r\nCloses: #61\r\n\r\n[1] https://nim-lang.org/blog/2021/10/19/version-160-released.html#strict-effects\r\n[2] https://github.com/nim-lang/Nim/commit/1e15f975b839\r\n[3] bb903611e915, \"patches for strict effects\", 2022-10-24\r\n[4] https://forum.nim-lang.org/t/9716","shortMessageHtmlLink":"parsetoml: support compiling with strictFuncs again (#62)"}},{"before":"ece84323e18372cc96c8b3f3a8a9007fc17a1acd","after":"6ea23f25d89d1b5b5f8d985cf9f0019d3b4ac56b","ref":"refs/heads/gh-pages","pushedAt":"2023-06-15T10:49:11.003Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: fef0e983ef7ecb5bb008e75ca61092376a31b130","shortMessageHtmlLink":"deploy: fef0e98"}},{"before":"ed6ca4ee9fdd41bfc3cb0974612a85e7dff26b97","after":"fef0e983ef7ecb5bb008e75ca61092376a31b130","ref":"refs/heads/master","pushedAt":"2023-06-15T10:48:48.432Z","pushType":"push","commitsCount":1,"pusher":{"login":"ziotom78","name":"Maurizio Tomasi","path":"/ziotom78","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/377795?s=80&v=4"},"commit":{"message":"Create .readthedocs.yaml","shortMessageHtmlLink":"Create .readthedocs.yaml"}},{"before":"7062abd8057b6f3cf317f48a4799e9c2a198741d","after":"ece84323e18372cc96c8b3f3a8a9007fc17a1acd","ref":"refs/heads/gh-pages","pushedAt":"2023-05-08T17:11:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"deploy: ed6ca4ee9fdd41bfc3cb0974612a85e7dff26b97","shortMessageHtmlLink":"deploy: ed6ca4e"}},{"before":"33520d8e6d2e993157eeb08d46b6c5f058a32cb7","after":"ed6ca4ee9fdd41bfc3cb0974612a85e7dff26b97","ref":"refs/heads/master","pushedAt":"2023-05-08T17:11:24.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"PMunch","name":"Peter Munch-Ellingsen","path":"/PMunch","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2845482?s=80&v=4"},"commit":{"message":"parsetoml: make TomlError a non-Defect again (#57)\n\nWe should be able to catch an exception if we parse invalid TOML, and\r\nparsetoml raises a TomlError for such a situation. However, commits\r\n668491edaff1 and 7126677392aa changed TomlError from an Exception to a\r\nDefect when compiling with Nim 1.4.0 or newer.\r\n\r\nFrom the Nim Manual [1][2], a Defect should not be caught:\r\n\r\n The exception tree is defined in the `system `_ module.\r\n Every exception inherits from `system.Exception`. Exceptions that indicate\r\n programming bugs inherit from `system.Defect` (which is a subtype of `Exception`)\r\n and are strictly speaking not catchable as they can also be mapped to an operation\r\n that terminates the whole process. If panics are turned into exceptions, these\r\n exceptions inherit from `Defect`.\r\n\r\n Exceptions that indicate any other runtime error that can be caught inherit from\r\n `system.CatchableError` (which is a subtype of `Exception`).\r\n\r\n [...]\r\n\r\n Exceptions inheriting from `system.Defect` are not tracked with\r\n the `.raises: []` exception tracking mechanism. This is more consistent with the\r\n built-in operations. The following code is valid:\r\n\r\n ```nim\r\n proc mydiv(a, b): int {.raises: [].} =\r\n a div b # can raise an DivByZeroDefect\r\n ```\r\n\r\nMake TomlError catchable again, making it inherit from a CatchableError\r\n(in particular, ValueError). This is consistent with e.g.\r\nstd/parsejson [3] and jsony [4].\r\n\r\n[1] https://github.com/nim-lang/Nim/blob/9f408ea9430b/doc/manual.md#exception-hierarchy\r\n[2] https://github.com/nim-lang/Nim/blob/9f408ea9430b/doc/manual.md#exception-tracking\r\n[3] https://github.com/nim-lang/Nim/blob/9f408ea9430b/lib/pure/parsejson.nim#L79\r\n[4] https://github.com/treeform/jsony/blob/d0e69bddf838/src/jsony.nim#L3","shortMessageHtmlLink":"parsetoml: make TomlError a non-Defect again (#57)"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADZLMlJwA","startCursor":null,"endCursor":null}},"title":"Activity ยท NimParsers/parsetoml"}