Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Sections containing csv_data_file are not loaded #478

Open
javierbg opened this issue Feb 4, 2020 · 0 comments
Open

Sections containing csv_data_file are not loaded #478

javierbg opened this issue Feb 4, 2020 · 0 comments

Comments

@javierbg
Copy link
Contributor

javierbg commented Feb 4, 2020

In commit 25e6204, the way that CSV data files were handled was last modified. Specifically, in niftynet.io.image_sets_partitioner.ImageSetsPartitioner, method load_data_sections_by_subject:

        for section_name in self.data_param:

            if isinstance(self.data_param[section_name], dict):
                mod_spec = self.data_param[section_name]
            else:
                mod_spec = vars(self.data_param[section_name])
            if mod_spec.get('csv_data_file', None):  # has csv_data_file
                # skip file search
                continue

This skips all sections where a 'csv_data_file' has been specified. I can't find the part of the code where these sections are supposed to be loaded, and can't find a reference documenting this.

I was looking into this because currently I have to perform a "hack" in order to input the class label as conditioning data in GANApplication, where I need to pass the label as a 1x1x1 image for each subject. Also, for ClassificationApplication, how would the class label be specified? Is this a bug? I am willing to submit a pull request fixing this, but I wanted to make sure that I understand the reason behind this fully.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant