Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Reddit comments sorted by "new" are indexed/deleted. #67

Open
CavemanIke opened this issue Aug 1, 2020 · 3 comments
Open

Only Reddit comments sorted by "new" are indexed/deleted. #67

CavemanIke opened this issue Aug 1, 2020 · 3 comments

Comments

@CavemanIke
Copy link

CavemanIke commented Aug 1, 2020

The app is not indexing or deleting all comments. It seems the app is only gathering data which is sorted by "new" on Reddit by default. Changing this setting on Reddit does not affect the app. It may be that a different API call or modification of the current one is needed to properly index all comments and perform the deletions.

image

@Nick-Gottschlich
Copy link
Owner

Nick-Gottschlich commented Aug 2, 2020

Hello! Thank you for trying out Social Amnesia!

You are correct, the API call I make now for reddit will start at the newest comment, and index 1000 items back, sorted by new. It looks like it is possible to sort by hot/top/new/controversial using the settings in this API call: https://www.reddit.com/dev/api#GET_user_{username}_comments . This is a good idea for future functionality for the application!

However, one caveat of the reddit API is it only indexes the 1000 most recent comments, so I believe Social Amnesia won't be able to go any further back than that no matter what method of sorting is used. Do you know if the account you are using has more than 1000 comments that you are trying to access/delete?

@CavemanIke
Copy link
Author

It's not that it has 1000 comments it's trying to access, it's that because of the sorting method used (new) it is only able to access 4 comments out of around 500 or so in my history. I believe sorting by new shows comments only within a limited time range.

@Nick-Gottschlich
Copy link
Owner

Interesting, thanks for bringing that up! That would make sense as the vast majority of testing I did had been on comments that had been created within the recent past for testing purposes.

It should be relatively simple to add a dropdown that changes the method of sorting, I'll give that a shot and let you know. I might make a beta branch of some sort to send your way to see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants