Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$dumpvars frequently does not have an $end #11

Open
dvvgit opened this issue Mar 18, 2022 · 3 comments
Open

$dumpvars frequently does not have an $end #11

dvvgit opened this issue Mar 18, 2022 · 3 comments

Comments

@dvvgit
Copy link

dvvgit commented Mar 18, 2022

In many practical VCD files, the $dumpvars simply starts the value changes, and there is no matching $end. If this is the case, the parser dies when the first time record, say, #1234, is encountered, with a mysterious exception '1234'. One possible solution is to check for # in vcd_value_change. I can send you a proposed diff if you are interested (did not figure the way to attach it here).

Sincerely, Dima.

@Nic30
Copy link
Owner

Nic30 commented Mar 18, 2022

Hello @dvvgit ,

I can send you a proposed diff if you are interested

That would be nice, you can attach it to comment using just drag and drop to a message box.
But it would be more professional to just create a pull request if you already have a fix for this issue.

Best regards, Nic30.

dvvgit pushed a commit to dvvgit/pyDigitalWaveTools that referenced this issue Mar 18, 2022
Nic30 added a commit that referenced this issue Mar 21, 2022
@Nic30
Copy link
Owner

Nic30 commented Mar 21, 2022

@dvvgit Nice. Now, do you have at least some simple example so we can add it to tests?

@dvvgit
Copy link
Author

dvvgit commented Mar 21, 2022

Here is a shortened version of the failing file.

test.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants