Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworking git module #7

Open
Nhoya opened this issue Jan 17, 2018 · 1 comment
Open

Reworking git module #7

Nhoya opened this issue Jan 17, 2018 · 1 comment
Assignees
Projects
Milestone

Comments

@Nhoya
Copy link
Owner

Nhoya commented Jan 17, 2018

At the moment the git module is limited to git API or memory space.
This can lead to 2 problems:

  • The git website API are too limited and will block the mail fetching + one request per 100 commits is not so good
  • Since the plain search is done cloning the entire repo in memory is not a really good thing with big repos

The possible solution was to implement the equivalent for git clone -n but is not currently supported from go-git and i don't want to depend from a wrapper like https://github.com/libgit2/git2go (pure go is always better), less dependencies, less problems

So I'm waiting the implementation of src-d/go-git/pull/721 to proceed with the reworking

The new module should be way faster and less resource hungry

@Nhoya Nhoya self-assigned this Jan 17, 2018
@Nhoya
Copy link
Owner Author

Nhoya commented Jan 18, 2018

Update: the PR was merged, waiting for the new release

@Nhoya Nhoya added this to Done in gOSINT Core Mar 6, 2018
@Nhoya Nhoya moved this from Done to TODO in gOSINT Core Mar 6, 2018
@Nhoya Nhoya moved this from TODO to In progress in gOSINT Core Mar 6, 2018
@Nhoya Nhoya moved this from In progress to Done in gOSINT Core Mar 6, 2018
@Nhoya Nhoya removed this from Done in gOSINT Core Mar 6, 2018
@Nhoya Nhoya added this to the 1.0.0 milestone Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Git Module
  
Awaiting triage
Development

No branches or pull requests

1 participant