Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divination Card prices are inaccurate #253

Open
remd opened this issue May 5, 2023 · 8 comments
Open

Divination Card prices are inaccurate #253

remd opened this issue May 5, 2023 · 8 comments

Comments

@remd
Copy link

remd commented May 5, 2023

I noticed while poking around in my Divination Card section that the prices are inaccurate to a degree that makes auto-sorting by price relatively useless.

Just to hand-pick a few that I noticed:
The Betrayal

  • FilterBlade: 4.6c
  • poe.ninja: 3.8c
  • poe.watch: 1.29c
  • trade listings (up to a day ago) start at: 1-2c

The Puzzle:

  • FilterBlade: 3.4c
  • poe.ninja: 1c
  • poe.watch: 1.91c
  • trade listings (up to a day ago) start at: 1-2c

Thirst For Knowledge:

  • FilterBlade: 5c
  • poe.ninja: 2c
  • poe.watch 1.65c
  • trade listings (up to a day ago) start at: 1-3c

Thirst of Knowledge has never cost 5c according to poe.ninja or poe.watch this entire league, but FilterBlade is reporting the price at 5c. Why?

Thirst For Knowledge is particular interesting because FilterBlade reports in the Unique Item section that Gluttony is priced at 2.4c. The 5 cards required to get a Gluttony from div cards would cost 25c, but the item that results from that stack of cards is priced at 2.4c. It seems like FilterBlade could internally check its Divination Card prices against the Unique Item prices for logical consistency.

I haven't extensively looked through all the cards so I assume that in most cases FilterBlade is reporting a price higher than actual, but I wonder if it ever reports a price lower than actual, which would be even more concerning.

Thank you for your hard work on this amazing tool. I greatly appreciate it.

@NeverSinkDev
Copy link
Owner

Hey, thank you for the issue.

Filterblade takes it's economy data straight from poe.ninja.

The filter generation actually does check the resulting reward, from most unique and currency related div cards.

We'll check if the script for poe.ninja is working correctly

@remd
Copy link
Author

remd commented May 17, 2023

I just realized that my poe.ninja settings were set to Sanctum prices. 😳 I apologize for the incorrect and misleading data.

However, poe.watch was set to Crucible and my trade searches were against Crucible. I think FilterBlade is grabbing the economy data correctly from poe.ninja although I'm not sure why poe.ninja inflates the prices of the cards so much.

@remd
Copy link
Author

remd commented May 29, 2023

Just a passing thought I had on this. Would it be possible to offer fetching prices via poe.watch as an alternative?

They have an API available at https://docs.poe.watch/ and from a cursory look have the same items listed that poe.ninja lists. One thing I see missing is item base types but I don't think FilterBlade offers item base type price import (please correct me if I'm wrong).

At least their divination card prices seem to be much more accurate. Thirst For Knowledge currently sits at 4c on poe.ninja but poe.watch shows it as 1.35c which looks to be much closer to what the trade listings are currently sitting at. From personal experience pricing Orb of Chance, Orb of Fusing, and Delirium Orbs from poe.watch seems to be more accurate with those as well.

@jpwalsh1
Copy link

div prices are still out of wack, its flagging 1c cards for me when there is no reason why we need to be picking these up

@NeverSinkDev
Copy link
Owner

div prices are still out of wack, its flagging 1c cards for me when there is no reason why we need to be picking these up

Please provide context.

Version, strictness, card, price, details etc

@jpwalsh1
Copy link

12/27

Very Strict

T14 Jungle Valley

Cards that still showed up on filter (all 1c at best)

Emperor's Luck
Lantador's
Fathomless

Very strict should not be showing me 1c cards anymore, or making any noise for them either.

@jpwalsh1
Copy link

jpwalsh1 commented Dec 28, 2023

image

Ran a delly map, 10 cards in there the very strict filter told me to pick up. 1 of them is valued more than 1c.

The Lion
The Penitent
The Gemcutter
The Wrath
The Calling
The Trial
Vinia's Token
Lost Worlds
The Wolf

The one worth more than 1c, was The Breach.

Expecting 'economy updates' in the filter, will sort uniques, cards, gems, etc based on the current poe.ninja tables without us needing to go manually edit the loot filter.

@NeverSinkDev
Copy link
Owner

Very strict still shows a lot of random cards with potentially interesting outcomes and currency-like items.
Additionally use the latest version, many of the examples are actually hidden.

Emperor's Luck - highly random, fun, grants currency
Lantador's - hidden
Fathomless - hidden
Lion - random outcome with chance for jewel, ok
Penitent - Tricky one, large random pool, hidden on uber-strict as intended, but I see your point here.
Gemcutter - hidden
Wrath - Shown and it's ok
Calling - hidden
Trial - hidden
Vinia's - shown and ok
lost words - hidden
wolf - similar to penitent

Overall:

  • Use latest version
  • Upgrade to uber-strict

I'll be doing some readjustments to the expectations of the individual strictness experience, but your examples seem in the acceptable range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants