You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In source code(https://github.com/Netflix/zuul/blob/2.1/zuul-core/src/main/java/com/netflix/zuul/message/http/HttpQueryParams.java#L118), we can see get() method uses name.toLowerCase() as key, while getFirst() method uses original name.
public List get(String name)
{
return delegate.get(name.toLowerCase());
}
Suppose current url is xxx?cityId[]=1&cityId[]=2, invoke get("cityId") would cause none value which is not expected. Is there any special reason to use lower case of param key rather than original key?
The text was updated successfully, but these errors were encountered:
Hello @artgon I fixed this issue on #1672, Could you please take a moment to review it?
If possible, I would also like to request @sullis to kindly join in reviewing this PR.
Your cooperation is highly appreciated.
In source code(https://github.com/Netflix/zuul/blob/2.1/zuul-core/src/main/java/com/netflix/zuul/message/http/HttpQueryParams.java#L118), we can see get() method uses name.toLowerCase() as key, while getFirst() method uses original name.
public List get(String name)
{
return delegate.get(name.toLowerCase());
}
Suppose current url is xxx?cityId[]=1&cityId[]=2, invoke get("cityId") would cause none value which is not expected. Is there any special reason to use lower case of param key rather than original key?
The text was updated successfully, but these errors were encountered: