Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zuul2 HttpQueryParams get() method issue #527

Open
jiangsuxd opened this issue Oct 19, 2018 · 3 comments · May be fixed by #1672
Open

zuul2 HttpQueryParams get() method issue #527

jiangsuxd opened this issue Oct 19, 2018 · 3 comments · May be fixed by #1672

Comments

@jiangsuxd
Copy link

In source code(https://github.com/Netflix/zuul/blob/2.1/zuul-core/src/main/java/com/netflix/zuul/message/http/HttpQueryParams.java#L118), we can see get() method uses name.toLowerCase() as key, while getFirst() method uses original name.
public List get(String name)
{
return delegate.get(name.toLowerCase());
}
Suppose current url is xxx?cityId[]=1&cityId[]=2, invoke get("cityId") would cause none value which is not expected. Is there any special reason to use lower case of param key rather than original key?

@artgon
Copy link
Contributor

artgon commented Oct 31, 2018

Good question, will look into it.

@mrlee7
Copy link

mrlee7 commented Oct 12, 2023

Hello @artgon,
Can I create a PR and handle the issue?
If possible, do you have any thoughts or opinions on this issue?

@mrlee7
Copy link

mrlee7 commented Nov 2, 2023

Hello @artgon I fixed this issue on #1672, Could you please take a moment to review it?
If possible, I would also like to request @sullis to kindly join in reviewing this PR.
Your cooperation is highly appreciated.

Thanks (_ _)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants