Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the timeline view state part of the URL #42

Open
romain-intel opened this issue Dec 7, 2021 · 1 comment
Open

Make the timeline view state part of the URL #42

romain-intel opened this issue Dec 7, 2021 · 1 comment
Assignees

Comments

@romain-intel
Copy link
Contributor

Summary

One of the interesting features of the UI is the ability to share a URL and have the recipient of the URL see the same thing. This doesn't work though for timeline view where the state of the expand/collapse step view is not kept around in the URL and revert back to a default setting. This makes it hard to share a timeline view that shows a specific task or set of tasks. It would be nice if this could be kept.

Motivation

See above

Describe alternatives you've considered

Alternative would be as it is today. Another alternative might be to have a button to create a "shared URL". The reason for this is that putting it in the URL would mess with the back behavior which may not be desired.

Additional context

The behavior of the "back" button needs to be considered.

@rsanteri rsanteri self-assigned this Dec 8, 2021
@rsanteri
Copy link
Contributor

Some challenges with this one is also runs with massive amount of tasks and steps. If user is checking run with 10k rows and has most of steps closed, it might take a while for tasks for open steps to show up. This probably should affect to fetching order for tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants