Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing input type from schema does not remove generated type #594

Open
dwbutler opened this issue Aug 24, 2023 · 2 comments
Open

Removing input type from schema does not remove generated type #594

dwbutler opened this issue Aug 24, 2023 · 2 comments

Comments

@dwbutler
Copy link

My Netflix DGS project is using com.netflix.graphql.dgs.codegen:graphql-dgs-codegen-shared-core=5.4.0

On my local machine, I was developing a new schema with a new input type. Netflix DGS generated the input type, I wrote code against it, everything was good.

Then, I decided to rename the input type to something else. I regenerated the schema using the generateJava task, everything was good. But I forgot to go into my application code and use the new input type name. Everything compiled so I thought it was good, so I pushed up to CI. It failed on the CI server because the old type name didn't exist anymore.

I would expect Netflix DGS to regenerate a clean set of classes each time by wiping out ALL of the existing generated code and generating all new files every time. Or at the very least, detecting code files that don't belong anymore and deleting them.

@srinivasankavitha
Copy link
Contributor

srinivasankavitha commented Aug 24, 2023 via email

@valterfab
Copy link

Hello, I can confirm that this is still happening on v6.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants