Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to the newest choices.scss? #5

Open
SonOfCrypto opened this issue Feb 19, 2018 · 3 comments
Open

Update to the newest choices.scss? #5

SonOfCrypto opened this issue Feb 19, 2018 · 3 comments

Comments

@SonOfCrypto
Copy link

Is there a chance of importing the latest choices from npm and not including it in your module? The sass styles changed a lot.

newest choices
https://github.com/jshjohnson/Choices/blob/master/assets/styles/scss/choices.scss

nb-choices
https://github.com/NetanelBasal/nb-choices/blob/master/nb-choices.scss
@NetanelBasal
Copy link
Owner

But I am providing a newer design, what is your purpose?

@SonOfCrypto
Copy link
Author

Oh ok, I thought it is a older version, not your own theme.

The "caret" svg is not working for me in Firefox
"xml parsing error unclosed token"

Maybe you could add something like "use-default-style" or so?

@NetanelBasal
Copy link
Owner

You mean fallback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SonOfCrypto @NetanelBasal