Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeItemButton is not adding a 'x' to single select #2

Open
ganeshkantu opened this issue Jan 30, 2018 · 4 comments
Open

removeItemButton is not adding a 'x' to single select #2

ganeshkantu opened this issue Jan 30, 2018 · 4 comments

Comments

@ganeshkantu
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request

Current behavior

The removeItemButton option which is set to true by default does not add a 'x' to single selects. Works correctly for multi-selects and text.

Expected behavior

If the removeItemButton option is set to true, an option to clear the value in single select should be added.

Minimal reproduction of the problem with instructions

The demo has this problem.

What is the motivation / use case for changing the behavior?

This option works correctly in choices.js. This wrapper should replicate that behavior.

Environment


Angular version: 5.1.0


Browser:
- [x] Chrome (desktop) version XX
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
Others:

@NetanelBasal
Copy link
Owner

Hey,

The single select does not support the x button.

@ganeshkantu
Copy link
Author

Hey - thanks for the lib btw!

Take a look at the demo page for choices.js - https://joshuajohnson.co.uk/Choices/
Scroll down to single select - there is a demo with a remove button which is used to clear the selection.

@NetanelBasal
Copy link
Owner

Yes, because design changes, I dropped the support, for now, I don't have time right now, so if you want this, I would love to see a pull request.

@ganeshkantu
Copy link
Author

Cool. Will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants