Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No options of CSI images location in the "tridentctl install" #311

Closed
ysakashita opened this issue Nov 7, 2019 · 6 comments
Closed

No options of CSI images location in the "tridentctl install" #311

ysakashita opened this issue Nov 7, 2019 · 6 comments

Comments

@ysakashita
Copy link

I would like to install Trident v19.10.0 using our private container repository.
So tridentctl already has a nice option called --trident-image .
But I can't specify the location for CSI images(csi-provisioner, csi-attacher etc).

Do you have a plan to support the options?

@clintonk
Copy link
Contributor

clintonk commented Nov 7, 2019

Hello, @ysakashita. You can use the --generate-custom-yaml switch to generate all the YAML that the installer needs, modify that accordingly, and then specify the --use-custom-yaml switch for the actual installation.

@techguydave
Copy link

I'm curious why an option wasn't provided for CSI images. Would you accept a PR to add the flag?

@clintonk
Copy link
Contributor

clintonk commented Nov 7, 2019

@synth3tk There are multiple CSI sidecars (and their versions differ somewhat between K8S versions) and we're not inclined to add that many flags to the installer. The custom YAML mechanism provides all the control needed (maybe too much!).

@wonderland
Copy link

What about a generic flag that just specifies the custom repo to use for all images? In cases like this, you'd typically have all images in the same private repo so we wouldn't require individual installer flags for each image. And would still make this easier than going through the whole YAML just for the (pretty much standard) use case of a private repo...

@clintonk
Copy link
Contributor

clintonk commented Nov 7, 2019

@wonderland That may be a reasonable compromise, although it could be a while. We're currently monitoring the trend toward K8S operators, so the Trident install method may change down the road anyway, and this is good feedback. In the meantime, using a caching image proxy like Nexus or Artifactory might be an option.

@ysakashita
Copy link
Author

@wonderland
+1 a generic flag
At least in my environment, I get all images from the same private repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants