{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":663451608,"defaultBranch":"master","name":"neptune-core","ownerLogin":"Neptune-Crypto","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-07-07T10:16:59.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/102594968?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715413545.0","currentOid":""},"activityList":{"items":[{"before":"e651a2948d70a221d0dd6fa8cb63f5299031e619","after":"4eeb345d4af8fc233968c34b53b5d95e0453fbf5","ref":"refs/heads/master","pushedAt":"2024-05-23T11:09:56.000Z","pushType":"pr_merge","commitsCount":15,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"Merge pull request #153 from Neptune-Crypto/thv/#145-reorganization-of-mempool\n\nThv/#145 reorganization of mempool","shortMessageHtmlLink":"Merge pull request #153 from Neptune-Crypto/thv/#145-reorganization-o…"}},{"before":"68a96cb051f41ac97d1514fa4bde7d830f14357f","after":"d76d3a69c06ba1065467ecf59db99f4c865b05e2","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-23T08:50:48.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"docs: Apply feedback on documentation of reorganization\n\nCo-authored-by: danda ","shortMessageHtmlLink":"docs: Apply feedback on documentation of reorganization"}},{"before":"167b452be1f53d81fafe8f21be0b23ccb93704ea","after":"e651a2948d70a221d0dd6fa8cb63f5299031e619","ref":"refs/heads/master","pushedAt":"2024-05-23T08:34:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"fix: Loosen CPU temp test requirement because CI\n\nThe GitHub CI doesn't return a temperature when calling the RPC\nendpoint `cpu_temp`, so the test is adjusted to just call the endpoint,\nnot expect a value to be returned.","shortMessageHtmlLink":"fix: Loosen CPU temp test requirement because CI"}},{"before":"4ba81ff9230e86e4212cd12fa4e5dc954d0944b5","after":"167b452be1f53d81fafe8f21be0b23ccb93704ea","ref":"refs/heads/master","pushedAt":"2024-05-22T11:17:10.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"docs: Improve error message on client startup\n\ndashboard might fail to start if the client is still initializing. This\ncommit adds that information to error messages if the dashboard fails to\nconnect to the client.","shortMessageHtmlLink":"docs: Improve error message on client startup"}},{"before":"5136656341ca56b21f1cbe5fa5978ddfd8f1f57f","after":"68a96cb051f41ac97d1514fa4bde7d830f14357f","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-22T09:43:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"fix: docstring for creating a mempool instance","shortMessageHtmlLink":"fix: docstring for creating a mempool instance"}},{"before":"2a907b06d765f84b3e4ec3cc522f9db348192626","after":"5136656341ca56b21f1cbe5fa5978ddfd8f1f57f","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-22T09:43:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"devops: Add doctests to Makefile recipe\n\n`nextest` doesn't run doc-tests. They need to be run separately.","shortMessageHtmlLink":"devops: Add doctests to Makefile recipe"}},{"before":"361209d201ad18bafa790cf9bf8737654f8e40ed","after":"2a907b06d765f84b3e4ec3cc522f9db348192626","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-21T11:54:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"docs: Describe state element's tolerance to reorganizations","shortMessageHtmlLink":"docs: Describe state element's tolerance to reorganizations"}},{"before":"5c296cf00a7b87454b84204e83b360b7d9fed0cc","after":"361209d201ad18bafa790cf9bf8737654f8e40ed","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-21T11:51:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"docs: Describe state element's tolerance to reorganizations","shortMessageHtmlLink":"docs: Describe state element's tolerance to reorganizations"}},{"before":"f97a4c806fdec34de5999128369ae365f311dc23","after":"5c296cf00a7b87454b84204e83b360b7d9fed0cc","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-21T11:24:39.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"fix: Failing doctest example for new mempool\n\nThe mempool must now be initialized with a tip digest in order to keep\ntrack of blocks for which the mempools transactions are valid. This is\nintroduced to allow the mempool to handle reorganizations without\ncontaining invalid transactions.","shortMessageHtmlLink":"fix: Failing doctest example for new mempool"}},{"before":"2d7700926cb0795054127359cd205ad8524156bf","after":"f97a4c806fdec34de5999128369ae365f311dc23","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-16T13:46:25.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"mempool: add warning about caller-responsibility cf. future timestamps","shortMessageHtmlLink":"mempool: add warning about caller-responsibility cf. future timestamps"}},{"before":"ccd30c937ae59a02c666afdd8f3dde05f93b97ca","after":"2d7700926cb0795054127359cd205ad8524156bf","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-16T13:41:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"mempool: add warning about caller-responsibility cf. future timestamps","shortMessageHtmlLink":"mempool: add warning about caller-responsibility cf. future timestamps"}},{"before":"2d7700926cb0795054127359cd205ad8524156bf","after":"ccd30c937ae59a02c666afdd8f3dde05f93b97ca","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-16T13:37:55.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"WIP","shortMessageHtmlLink":"WIP"}},{"before":"e215cb05f1dfe780b246aafb0e63301a708ed85b","after":"4ba81ff9230e86e4212cd12fa4e5dc954d0944b5","ref":"refs/heads/master","pushedAt":"2024-05-16T13:36:42.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"Merge pull request #150 from Neptune-Crypto/thv/fix-block-timestamp-test-flakyness\n\nFix flakyness of block timestamp test","shortMessageHtmlLink":"Merge pull request #150 from Neptune-Crypto/thv/fix-block-timestamp-t…"}},{"before":"5ef2423677e387387ba6b3cfb7c0ffc58f57c913","after":"e215cb05f1dfe780b246aafb0e63301a708ed85b","ref":"refs/heads/master","pushedAt":"2024-05-14T04:53:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dan-da","name":null,"path":"/dan-da","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5110592?s=80&v=4"},"commit":{"message":"chore: cli wallet-status outputs pretty json\n\nChanges `neptune-cli wallet-status` to pretty-print json instead of\nusing wallet_status.to_string(), ie impl Display.\n\nThis change is motivated by the block explorer, which instructs users\nto obiain utxo-index from output of wallet-status, but previously the\nfield was unlabelled and the output was badly formatted mostly without\nnewlines, making it quite human unfriendly.\n\nWith this change:\n + the utxo index is labelled as: aocl_leaf_index\n + digests are nicely hex formatted instead of BFieldElement list.\n + the output is nicely formatted and human readable\n + the output is also machine readable","shortMessageHtmlLink":"chore: cli wallet-status outputs pretty json"}},{"before":"d165fe9642dc40f55c90241945384255c70cc1f9","after":"2d7700926cb0795054127359cd205ad8524156bf","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-11T20:15:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"mempool: add warning about caller-responsibility cf. future timestamps","shortMessageHtmlLink":"mempool: add warning about caller-responsibility cf. future timestamps"}},{"before":"48e2ede4d9fcf82cfc6b32b0ae95f229b73f3c87","after":"d165fe9642dc40f55c90241945384255c70cc1f9","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-11T20:10:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"mempool: Clear all transactions on reorganizations\n\nHandling reorganizations in the mempool is complicated. Not only does\nthe mutator set data need to be rolled back, but that is also the case\nfor the Triton VM proofs. The easiest solution would probably be to keep\ntrack of a few proofs for each transaction in the mempool such that roll\nbacks that are only a few blocks deep could be handled.\n\nCare also has to be given to repopulating the mempool with transactions\nthat were included in the blocks that are being rolled back. These might\nhave to go into the mempool again.\n\nThe current solution, though, is simply to clear the mempool in the case\nof a reorganization. This commit includes a test that this is handled\nin a sane way, and that the mempool does not get polluted with incorrect/\ndeprecated/unsynces witness data.\n\nThis closes #145.","shortMessageHtmlLink":"mempool: Clear all transactions on reorganizations"}},{"before":"fd3d42eac56597a40299b772582ac86906e171f6","after":"48e2ede4d9fcf82cfc6b32b0ae95f229b73f3c87","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-11T18:37:06.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"mmr: Fix validation of removal records\n\nDon't just check all included MMR membership proofs, but also verify\nthat the correct MMR membership proofs are included.\n\nThis closes #151.","shortMessageHtmlLink":"mmr: Fix validation of removal records"}},{"before":"ddbe53a9d72f8d162db02c73fc2df8f6fe730489","after":"fd3d42eac56597a40299b772582ac86906e171f6","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-11T11:39:22.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"feat(mutator-set): Add function to get active window's chunk index interval\n\nAdd a method that returns the highest and lowest (both inclusive) chunk\nindices represented in the active window.","shortMessageHtmlLink":"feat(mutator-set): Add function to get active window's chunk index in…"}},{"before":"0b212d1d140a1d3f9c754bdfaa80c7a52debd228","after":null,"ref":"refs/heads/thv/fix-rollback-issue","pushedAt":"2024-05-11T07:45:45.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"}},{"before":"f1b3d57e36de1bc1ac503e406fe39f495e04cfe6","after":"5ef2423677e387387ba6b3cfb7c0ffc58f57c913","ref":"refs/heads/master","pushedAt":"2024-05-10T23:41:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"dan-da","name":null,"path":"/dan-da","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5110592?s=80&v=4"},"commit":{"message":"chore: use twenty-first compat with blockexplorer\n\nUses cargo patch to update to a more recent version of twenty-first\n0.41 that is also used by the block-explorer.","shortMessageHtmlLink":"chore: use twenty-first compat with blockexplorer"}},{"before":"79583855f04227256a45f9c58e85c66f58554481","after":"ddbe53a9d72f8d162db02c73fc2df8f6fe730489","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-10T17:17:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"WIP","shortMessageHtmlLink":"WIP"}},{"before":null,"after":"79583855f04227256a45f9c58e85c66f58554481","ref":"refs/heads/thv/#145-reorganization-of-mempool","pushedAt":"2024-05-10T14:49:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"docs(mempool): Elaborate on mempool methods","shortMessageHtmlLink":"docs(mempool): Elaborate on mempool methods"}},{"before":"6f2cc59e0098aadaf8835290883d221575a2c66a","after":"d1e8e744011de5f21f4ee6f8ed323dcd47ae84c4","ref":"refs/heads/thv/fix-block-timestamp-test-flakyness","pushedAt":"2024-05-10T10:46:05.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"Fix flakyness of block timestamp test","shortMessageHtmlLink":"Fix flakyness of block timestamp test"}},{"before":null,"after":"6f2cc59e0098aadaf8835290883d221575a2c66a","ref":"refs/heads/thv/fix-block-timestamp-test-flakyness","pushedAt":"2024-05-10T10:44:51.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"Fix flakyness of block timestamp test","shortMessageHtmlLink":"Fix flakyness of block timestamp test"}},{"before":"5f9c9e8306808053882095a0762e3689031d0a22","after":"f1b3d57e36de1bc1ac503e406fe39f495e04cfe6","ref":"refs/heads/master","pushedAt":"2024-05-10T10:27:58.000Z","pushType":"pr_merge","commitsCount":14,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"Merge pull request #147 from Neptune-Crypto/thv/fix-rollback-issue\n\nThv/fix rollback issue","shortMessageHtmlLink":"Merge pull request #147 from Neptune-Crypto/thv/fix-rollback-issue"}},{"before":"65b283c74f42a266d7e8b678380f815474e928e4","after":"0b212d1d140a1d3f9c754bdfaa80c7a52debd228","ref":"refs/heads/thv/fix-rollback-issue","pushedAt":"2024-05-10T10:25:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"Fix name of test-helper function after upstream changes","shortMessageHtmlLink":"Fix name of test-helper function after upstream changes"}},{"before":"b7bda001f39fc8a60dff538dd23a21c6587dbc46","after":"65b283c74f42a266d7e8b678380f815474e928e4","ref":"refs/heads/thv/fix-rollback-issue","pushedAt":"2024-05-10T10:17:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"docs(tip-updater): Elaborate on comments in method to update tip\n\nAlso changes the fn name of the internal worker to match that of the\nouter methods.","shortMessageHtmlLink":"docs(tip-updater): Elaborate on comments in method to update tip"}},{"before":"e4276d802214f88eb298a85a68e104814815c9c8","after":"5f9c9e8306808053882095a0762e3689031d0a22","ref":"refs/heads/master","pushedAt":"2024-05-08T22:34:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"dan-da","name":null,"path":"/dan-da","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5110592?s=80&v=4"},"commit":{"message":"feat: make block timestamp repr time block found\n\nCloses #149.\n\nThe mining loop now updates block_header.timestamp with current time\nbefore calculating each digest. This means that the timestamp will\nrepresent the moment a block is found, rather than the moment mining\nstarted, as it was before.\n\nChanges:\n * adds Block::set_header_timestamp()\n * call Block::set_header_timestamp(Timestamp::now()) in mining loop\n\nThe test `block_timestamp_represents_time_block_found()` now passes.","shortMessageHtmlLink":"feat: make block timestamp repr time block found"}},{"before":"dde24206f7825cf2628f3ce9789a0eb3b2193402","after":"b7bda001f39fc8a60dff538dd23a21c6587dbc46","ref":"refs/heads/thv/fix-rollback-issue","pushedAt":"2024-05-08T14:14:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"fix(test): Fix flaky timelock test\n\nThe timelock test was flaky since it often overflowed on the addition of\ntwo `BfieldElement`'s.\n\nThis closes #148.","shortMessageHtmlLink":"fix(test): Fix flaky timelock test"}},{"before":"3de0e42c8c1088980abe11880cdf467b038eac09","after":"dde24206f7825cf2628f3ce9789a0eb3b2193402","ref":"refs/heads/thv/fix-rollback-issue","pushedAt":"2024-05-07T21:08:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"Sword-Smith","name":"Thorkil Værge","path":"/Sword-Smith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8418024?s=80&v=4"},"commit":{"message":"Fix tests after redefining behavior of `set_new_tip`\n\nAfter redefining the behavior of the `set_new_tip` to update global state\nwith a new block, the function formerly known as `store_block`, we need\nto rearrange the order in which blocks are added in a few tests. With these\nchanges, all tests pass, and #143 is closed.","shortMessageHtmlLink":"Fix tests after redefining behavior of set_new_tip"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEUenxYQA","startCursor":null,"endCursor":null}},"title":"Activity · Neptune-Crypto/neptune-core"}