Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track validation of begin/end is failing #349

Open
NeoCoderMatrix86 opened this issue Apr 15, 2024 · 3 comments
Open

Track validation of begin/end is failing #349

NeoCoderMatrix86 opened this issue Apr 15, 2024 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@NeoCoderMatrix86
Copy link
Owner

Validation of the fields begin and end of a track is wrong, since you can enter an end that is before the begin. The track is just invalid because of the empty length.

grafik

@NeoCoderMatrix86 NeoCoderMatrix86 added this to the 5.0 milestone Apr 15, 2024
@NeoCoderMatrix86 NeoCoderMatrix86 added bug Something isn't working good first issue Good for newcomers labels Apr 15, 2024
@agusaar
Copy link

agusaar commented Apr 15, 2024

I would like to work on it

@NeoCoderMatrix86
Copy link
Owner Author

@agusaar:
Thank you for your interest, you are welcome to take this issue. I'll write down just a few thoughts, hoping it makes you easier to get onboard.
Basically I would assume that a track begin is equal or less to its end and equal or greater to zero. End should be greater or equal to Begin.
The validation is done inside each entity, so the Track entity has a Validate() method, where this can be achieved.
Do not forget to add a unit tests to check the begin and end validation (there are examples inside the unit tests).
So, I hope you can start, if you have a question, just ask ;).

@NeoCoderMatrix86
Copy link
Owner Author

@agusaar: Any progress here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Current Sprint
Development

No branches or pull requests

2 participants